Don't cancel outstanding connect jobs when "flushing" socket pool.

net/socket/client_socket_pool_base.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/socket/client_socket_pool_base.h"
 
 #include "base/compiler_specific.h"
 #include "base/format_macros.h"
 #include "base/message_loop.h"
 #include "base/stats_counters.h"
@@ skipping 635 matching lines @@
     }
   }
 }
 
 void ClientSocketPoolBaseHelper::OnIPAddressChanged() {
   Flush();
 }
 
 void ClientSocketPoolBaseHelper::Flush() {
   pool_generation_number_++;
-  CancelAllConnectJobs();

[Mike Belshe, 2010/07/29 09:18:42]

This might not be the best fix.

Another way to go would be to add code to do the notifications.

I believe it would go into CancelAllConnectJobs and look like this:

  while (group.pending_requests.size()) {
    scoped_ptr<const Request> request(
        RemoveRequestFromQueue(
          group.pending_requests.begin(),
          &group.pending_requests));
    InvokeUserCallbackLater(r->handle(), r->callback(), ERR_ABORTED);
  }


If you don't do it this way, then we're not being 100% clean on our flushing,
which effects benchmarks and such.

   CloseIdleSockets();
 }
 
 void ClientSocketPoolBaseHelper::RemoveConnectJob(const ConnectJob* job,
                                                   Group* group) {
   CHECK_GT(connecting_socket_count_, 0);
   connecting_socket_count_--;
 
   DCHECK(group);
   DCHECK(ContainsKey(group->jobs, job));
@@ skipping 149 matching lines @@
   CHECK(!handle->is_initialized());
   CompletionCallback* callback = it->second.callback;
   int result = it->second.result;
   pending_callback_map_.erase(it);
   callback->Run(result);
 }
 
 }  // namespace internal
 
 }  // namespace net