Issue 3027049: Addressed Tavis's comments in http://codereview.chromium.org/3023041/....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3027049: Addressed Tavis's comments in http://codereview.chromium.org/3023041/.... (Closed)

Created:
10 years, 4 months ago by Yusuke Sato

Modified:
9 years, 7 months ago

Reviewers:
agl, taviso

CC:
chromium-reviews

Base URL:
http://ots.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Addressed Tavis's comments in http://codereview.chromium.org/3023041/. - Modified 4-bytes 16.16 Fixed-point number decoder in ReadNextNumberFromType2CharString(). - Fixed off-by-one error in ExecuteType2CharStringOperator(). - Fixed checks of 'div' and 'endchar' operators. They were not strict enough. - Wrote ~1600 lines of test to verify if the modification above is valid. - Moved Type2CharStringOperator enum definition from cff_type2_charstriung.cc tocff_type2_charstriung.h to write the unit tests. BUG=51070 TEST=http://code.google.com/p/ots/wiki/HowToTestOts (Verified that the modified OTS rejects all malformed fonts, and does not reject all non-malformed fonts. I tested ~3400 TrueType and ~450 OpenType fonts.) TEST=ran cff_type2_charstring_test.

Patch Set 1 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1762 lines, -165 lines)			Patch
M	src/cff_type2_charstring.h	View	1 chunk	+53 lines, -0 lines	0 comments	Download
M	src/cff_type2_charstring.cc	View	30 chunks	+118 lines, -163 lines	0 comments	Download
M	test/SConstruct	View	2 chunks	+3 lines, -2 lines	0 comments	Download
A	test/cff_type2_charstring_test.cc	View	1 chunk	+1588 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

landed in r35. thanks.

Expand Messages | Collapse Messages