Issue 3027041: Remove obviously unneeded forward declarations in chrome/browser/[abef]*/*.h.

Issue 3027041: Remove obviously unneeded forward declarations in chrome/browser/[abef]/.h. (Closed)

Created:
10 years, 4 months ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
Lei Zhang, Elliot Glaysher

CC:
chromium-reviews, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

Remove obviously unneeded forward declarations in chrome/browser/[abef]*/*.h. BUG=none TEST=builds Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55136

Patch Set 2 : Did the same for browser/b/.h. #

Patch Set 3 : Do the same for browser/[ef]/.h. #

Patch Set 6 : oops, missed one previously #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -80 lines)			Patch
M	chrome/browser/autocomplete/autocomplete.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_win.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_popup_view_mac.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/autocomplete/history_url_provider.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/autofill/autofill_address_sheet_controller_mac.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/autofill/autofill_cc_infobar.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/automation/automation_provider.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/automation/automation_provider_json.h	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/automation/extension_port_container.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	chrome/browser/bookmarks/bookmark_context_menu_controller.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_drag_data.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_html_writer.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_html_writer.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model.h	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_storage.h	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/browser_accessibility_manager_win.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/execute_code_in_tab_function.h	View		3 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_bookmark_helpers.h	View	3 4	1 chunk	+8 lines, -2 lines	1 comment	Download
M	chrome/browser/extensions/extension_bookmark_helpers.cc	View	4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_bookmark_manager_api.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_bookmarks_module.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_cookies_helpers.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_cookies_helpers.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_data_deleter.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_devtools_bridge.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_devtools_browsertest.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_devtools_browsertest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_devtools_manager.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_disabled_infobar_delegate.h	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_disabled_infobar_delegate.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_dom_ui.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
	chrome/browser/extensions/extension_function_dispatcher.h	View		3 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/extensions/extension_host.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_install_ui.h	View		2 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_menu_manager.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_message_service.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_popup_api.h	View		2 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/extensions/extension_process_manager.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/gtk_theme_installed_infobar_delegate.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
	chrome/browser/extensions/sandboxed_extension_unpacker.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/extensions/user_script_master.h	View		2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

LGTM http://codereview.chromium.org/3027041/diff/12001/13019 File chrome/browser/extensions/extension_bookmark_helpers.h (left): http://codereview.chromium.org/3027041/diff/12001/13019#oldcode9 chrome/browser/extensions/extension_bookmark_helpers.h:9: #include "base/values.h" I'm removing unneeded headers one header ...

10 years, 4 months ago (2010-08-05 19:00:18 UTC) #2

viettrungluu

10 years, 4 months ago (2010-08-05 21:52:41 UTC) #3

Thanks.

On 2010/08/05 19:00:18, Lei Zhang wrote:
> LGTM
> 
> http://codereview.chromium.org/3027041/diff/12001/13019
> File chrome/browser/extensions/extension_bookmark_helpers.h (left):
> 
> http://codereview.chromium.org/3027041/diff/12001/13019#oldcode9
> chrome/browser/extensions/extension_bookmark_helpers.h:9: #include
> "base/values.h"
> I'm removing unneeded headers one header at a time - i.e. look over all
> #includes of base/values.h. I guess we'll conflict a bit here.

Hopefully the conflicts won't be too much trouble, but if they are, please let
me know.

Expand Messages | Collapse Messages