Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 3027024: Merge 63773 - 2010-07-20 Abhishek Arya <inferno@chromium.org>... (Closed)

Created:
10 years, 5 months ago by inferno
Modified:
9 years, 7 months ago
Reviewers:
inferno
CC:
chromium-reviews
Visibility:
Public.

Description

Merge 63773 - 2010-07-20 Abhishek Arya <inferno@chromium.org>; Reviewed by David Hyatt. Check the node is a text node before doing the static cast for editing commands. https://bugs.webkit.org/show_bug.cgi?id=42655 Test: editing/execCommand/editing-nontext-node-crash.xhtml * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::fixupWhitespace): * editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): * editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): 2010-07-20 Abhishek Arya <inferno@chromium.org>; Reviewed by David Hyatt. Tests that applying an editing command on a non text node does not result in crash. https://bugs.webkit.org/show_bug.cgi?id=42655 * editing/execCommand/editing-nontext-node-crash-expected.txt: Added. * editing/execCommand/editing-nontext-node-crash.xhtml: Added. BUG=49628 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53680

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -9 lines) Patch
A LayoutTests/editing/execCommand/editing-nontext-node-crash.xhtml View 1 chunk +36 lines, -0 lines 0 comments Download
A LayoutTests/editing/execCommand/editing-nontext-node-crash-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M WebCore/editing/DeleteSelectionCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M WebCore/editing/InsertLineBreakCommand.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M WebCore/editing/InsertParagraphSeparatorCommand.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
inferno
10 years, 5 months ago (2010-07-26 21:08:41 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698