Issue 3027009: Added size param to VerifyData()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3027009: Added size param to VerifyData() (Closed)

Created:
10 years, 5 months ago by Randall Spangler

Modified:
9 years, 7 months ago

Reviewers:
gauravsh, Bill Richardson

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://gitrw.chromium.org/vboot_reference.git

Visibility:
Public.

Description

Added size param to VerifyData() Also renamed verify preamble functions, now that they do not need the '2' at the end to differentiate them from the now-deleted original implementation. BUG=4501 TEST=Ran make runtests; all pass.

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -79 lines)			Patch
M	firmware/lib/include/vboot_common.h	View	3 chunks	+6 lines, -4 lines	0 comments	Download
M	firmware/lib/vboot_common.c	View	6 chunks	+10 lines, -6 lines	0 comments	Download
M	firmware/lib/vboot_firmware.c	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	firmware/lib/vboot_kernel.c	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	firmware/linktest/main.c	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	firmware/version.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/vboot_common2_tests.c	View	3 chunks	+35 lines, -29 lines	0 comments	Download
M	tests/vboot_common3_tests.c	View	2 chunks	+27 lines, -27 lines	0 comments	Download
M	utility/vbutil_firmware.c	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	utility/vbutil_kernel.c	View	2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages