Issue 3026043: Full screen video Chromium patch

Issue 3026043: Full screen video Chromium patch (Closed)

Created:
10 years, 4 months ago by boliu

Modified:
9 years, 6 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews, fbarchard, ben+cc_chromium.org, Erik does not do reviews, Alpha Left Google, Aaron Boodman, pam+watch_chromium.org, awong, brettw-cc_chromium.org, darin-cc_chromium.org, scherkus (not reviewing)

Visibility:
Public.

Description

Split into 2 patches: http://codereview.chromium.org/3164019/show http://codereview.chromium.org/3165028/show Corresponding WebKit patch at https://bugs.webkit.org/show_bug.cgi?id=43394 This patch should come after http://codereview.chromium.org/3055009/show so it is not actually that big. RenderView calls RenderWidgetFullscreen::Create and maintains the WebFullscreenMediaPlayers. The teardown sequence of full screen always involves the call RenderView::exitFullscreenForNode BUG=16735 TEST=Coming...

Patch Set 1 #

Patch Set 2 : Proper diff. Move enter/exitFullscreenForNode into WebKit. #

Patch Set 3 : Rename GetClient/SetClient to client/setClient to match WebKit style. #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -27 lines)			Patch
M	chrome/renderer/render_view.h	View	1	3 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	1	4 chunks	+6 lines, -8 lines	0 comments	Download
M	chrome/renderer/render_widget_fullscreen.cc	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	webkit/glue/webmediaplayer_impl.h	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	webkit/glue/webmediaplayer_impl.cc	View	1 2	7 chunks	+20 lines, -13 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

can you upload using "git cl upload <branch-to-diff-against>" I think I'm seeing both sets of ...

10 years, 4 months ago (2010-08-03 22:59:31 UTC) #1

scherkus (not reviewing)

also BUG= and TEST= fields to CL description

10 years, 4 months ago (2010-08-03 22:59:48 UTC) #2

boliu

Move enter/exitFullscreen into WebKit, matching WebPopupMenu.

10 years, 4 months ago (2010-08-03 23:10:18 UTC) #3

boliu

10 years, 4 months ago (2010-08-17 16:03:54 UTC) #5

Yes, eventually. This the patch coming after
http://codereview.chromium.org/3055009/show

I am splitting this patch into two such that the first one can be committed
without the webkit patch.

Expand Messages | Collapse Messages