Issue 3026030: Use hashlib module instead of md5 if it is present.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3026030: Use hashlib module instead of md5 if it is present. (Closed)

Created:
10 years, 4 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev, mnaganov (inactive)

Visibility:
Public.

Description

Use hashlib module instead of md5 if it is present. md5 module is deprecated since Python 2.5 and we'd better off using hashlib instead. Committed: http://code.google.com/p/v8/source/detail?r=5143

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	tools/presubmit.py	View		2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

antonm

Søren, may you have a look? I resort to md5 if hashlib is missing as ...

10 years, 4 months ago (2010-07-28 11:38:35 UTC) #1

LGTM

Expand Messages | Collapse Messages