chrome/browser/sync/syncable/directory_backing_store.h - Issue 3026029: Fix EntryKernel leak if sync database load fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/syncable/directory_backing_store.h

Issue 3026029: Fix EntryKernel leak if sync database load fails (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: Fix legit leak in PurgeEntriesWithTypeIn Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/syncable/directory_backing_store.h

diff --git a/chrome/browser/sync/syncable/directory_backing_store.h b/chrome/browser/sync/syncable/directory_backing_store.h

index 3739b3951a6ab8f24a1ae9a07f3a9bc9feeca827..e1b0cca57722f89b594e261c5b80dc51b6646540 100644

--- a/chrome/browser/sync/syncable/directory_backing_store.h

+++ b/chrome/browser/sync/syncable/directory_backing_store.h

@@ -123,6 +123,8 @@ class DirectoryBackingStore {

// Initialize and destroy load_dbhandle_. Broken out for testing.

bool BeginLoad();

void EndLoad();

+ DirOpenResult DoLoad(MetahandlesIndex* entry_bucket,

+ Directory::KernelLoadInfo* kernel_load_info);

// Close save_dbhandle_. Broken out for testing.

void EndSave();