The Mac wrench menu zoom controls honor the global enabled state of the zoom commands.

Exposed an IsEnabledAt for ButtonMenuItemModel (this is not used yet, will be used in a subsequent checkin). The Mac wrench menu zoom controls honor the global enabled state of the zoom commands. 

BUG=None. 
TEST=Open a PDF using the internal PDF viewer on the Mac. The Zoom controls on the Wrench menu should be disabled.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53824

[Robert Sesek, 2010-07-27 01:17:02]

Please add some new lines in your CL description to break up the BUG= and TEST=
lines.

http://codereview.chromium.org/3026025/diff/4001/5001
File app/menus/button_menu_item_model.cc (right):

http://codereview.chromium.org/3026025/diff/4001/5001#newcode107
app/menus/button_menu_item_model.cc:107:
delegate_->IsCommandIdEnabled(items_[index].command_id);
Missing a return statement.

http://codereview.chromium.org/3026025/diff/4001/5002
File app/menus/button_menu_item_model.h (right):

http://codereview.chromium.org/3026025/diff/4001/5002#newcode82
app/menus/button_menu_item_model.h:82: bool IsEnabledAt(int index);
const method?

http://codereview.chromium.org/3026025/diff/4001/5003
File chrome/browser/cocoa/wrench_menu_controller.mm (right):

http://codereview.chromium.org/3026025/diff/4001/5003#newcode77
chrome/browser/cocoa/wrench_menu_controller.mm:77: bool plus_enabled = [self
wrenchMenuModel]->IsCommandIdEnabled(IDC_ZOOM_PLUS);
In ObjC, the convention is to use camelCase for variable names.

http://codereview.chromium.org/3026025/diff/4001/5003#newcode81
chrome/browser/cocoa/wrench_menu_controller.mm:81: [zoomPlus_ setEnabled:
plus_enabled];
There are no spaces after the colons in ObjC method calls. This should read:
  [zoomPlus_ setEnabled:plusEnabled];

[sanjeevr, 2010-07-27 02:14:55]

Made all the changes.

Also fixed the description. I am trying git for the first time (have always used
svn) and I messed up the description file.

http://codereview.chromium.org/3026025/diff/4001/5001
File app/menus/button_menu_item_model.cc (right):

http://codereview.chromium.org/3026025/diff/4001/5001#newcode107
app/menus/button_menu_item_model.cc:107:
delegate_->IsCommandIdEnabled(items_[index].command_id);
On 2010/07/27 01:17:02, rsesek wrote:
> Missing a return statement.

Oops. Done.

http://codereview.chromium.org/3026025/diff/4001/5002
File app/menus/button_menu_item_model.h (right):

http://codereview.chromium.org/3026025/diff/4001/5002#newcode82
app/menus/button_menu_item_model.h:82: bool IsEnabledAt(int index);
On 2010/07/27 01:17:02, rsesek wrote:
> const method?

Done.

http://codereview.chromium.org/3026025/diff/4001/5003
File chrome/browser/cocoa/wrench_menu_controller.mm (right):

http://codereview.chromium.org/3026025/diff/4001/5003#newcode77
chrome/browser/cocoa/wrench_menu_controller.mm:77: bool plus_enabled = [self
wrenchMenuModel]->IsCommandIdEnabled(IDC_ZOOM_PLUS);
On 2010/07/27 01:17:02, rsesek wrote:
> In ObjC, the convention is to use camelCase for variable names.

Done.

http://codereview.chromium.org/3026025/diff/4001/5003#newcode81
chrome/browser/cocoa/wrench_menu_controller.mm:81: [zoomPlus_ setEnabled:
plus_enabled];
On 2010/07/27 01:17:02, rsesek wrote:
> There are no spaces after the colons in ObjC method calls. This should read:
>   [zoomPlus_ setEnabled:plusEnabled];

Done.

[Robert Sesek, 2010-07-27 14:53:22]

http://codereview.chromium.org/3026025/diff/15002/22003
File chrome/browser/cocoa/wrench_menu_controller.mm (right):

http://codereview.chromium.org/3026025/diff/15002/22003#newcode83
chrome/browser/cocoa/wrench_menu_controller.mm:83: [zoomDisplay_
setEnabled:plusEnabled || minusEnabled];
Remove this. |zoomDisplay_| should always be disabled.

[sanjeevr, 2010-07-27 17:27:07]

http://codereview.chromium.org/3026025/diff/15002/22003
File chrome/browser/cocoa/wrench_menu_controller.mm (right):

http://codereview.chromium.org/3026025/diff/15002/22003#newcode83
chrome/browser/cocoa/wrench_menu_controller.mm:83: [zoomDisplay_
setEnabled:plusEnabled || minusEnabled];
On 2010/07/27 14:53:22, rsesek wrote:
> Remove this. |zoomDisplay_| should always be disabled.

Done.

[Robert Sesek, 2010-07-27 17:41:41]

LGTM