src/x64/codegen-x64.h - Issue 3026019: Fix bug in r5123, Comparison(), by unusing results before unconditional jump ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/codegen-x64.h

Issue 3026019: Fix bug in r5123, Comparison(), by unusing results before unconditional jump ... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/codegen-x64.h

===================================================================

--- src/x64/codegen-x64.h (revision 5123)

+++ src/x64/codegen-x64.h (working copy)

@@ -495,10 +495,8 @@

// Emits code sequence that jumps to a JumpTarget if the inputs

// are both smis. Cannot be in MacroAssembler because it takes

// advantage of TypeInfo to skip unneeded checks.

- void JumpIfBothSmiUsingTypeInfo(Register left,

- Register right,

- TypeInfo left_info,

- TypeInfo right_info,

+ void JumpIfBothSmiUsingTypeInfo(Result* left,

+ Result* right,

JumpTarget* both_smi);

// Emits code sequence that jumps to deferred code if the input

« no previous file with comments | « src/ia32/codegen-ia32.cc ('k') | src/x64/codegen-x64.cc » ('j') | no next file with comments »