Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: src/x64/codegen-x64.h

Issue 3026019: Fix bug in r5123, Comparison(), by unusing results before unconditional jump ... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/codegen-ia32.cc ('k') | src/x64/codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 477 matching lines...) Expand 10 before | Expand all | Expand 10 after
488 488
489 // Generate code that computes a shortcutting logical operation. 489 // Generate code that computes a shortcutting logical operation.
490 void GenerateLogicalBooleanOperation(BinaryOperation* node); 490 void GenerateLogicalBooleanOperation(BinaryOperation* node);
491 491
492 void GenericBinaryOperation(BinaryOperation* expr, 492 void GenericBinaryOperation(BinaryOperation* expr,
493 OverwriteMode overwrite_mode); 493 OverwriteMode overwrite_mode);
494 494
495 // Emits code sequence that jumps to a JumpTarget if the inputs 495 // Emits code sequence that jumps to a JumpTarget if the inputs
496 // are both smis. Cannot be in MacroAssembler because it takes 496 // are both smis. Cannot be in MacroAssembler because it takes
497 // advantage of TypeInfo to skip unneeded checks. 497 // advantage of TypeInfo to skip unneeded checks.
498 void JumpIfBothSmiUsingTypeInfo(Register left, 498 void JumpIfBothSmiUsingTypeInfo(Result* left,
499 Register right, 499 Result* right,
500 TypeInfo left_info,
501 TypeInfo right_info,
502 JumpTarget* both_smi); 500 JumpTarget* both_smi);
503 501
504 // Emits code sequence that jumps to deferred code if the input 502 // Emits code sequence that jumps to deferred code if the input
505 // is not a smi. Cannot be in MacroAssembler because it takes 503 // is not a smi. Cannot be in MacroAssembler because it takes
506 // advantage of TypeInfo to skip unneeded checks. 504 // advantage of TypeInfo to skip unneeded checks.
507 void JumpIfNotSmiUsingTypeInfo(Register reg, 505 void JumpIfNotSmiUsingTypeInfo(Register reg,
508 TypeInfo type, 506 TypeInfo type,
509 DeferredCode* deferred); 507 DeferredCode* deferred);
510 508
511 // Emits code sequence that jumps to deferred code if the inputs 509 // Emits code sequence that jumps to deferred code if the inputs
(...skipping 571 matching lines...) Expand 10 before | Expand all | Expand 10 after
1083 return ObjectBits::encode(object_.code()) | 1081 return ObjectBits::encode(object_.code()) |
1084 AddressBits::encode(addr_.code()) | 1082 AddressBits::encode(addr_.code()) |
1085 ScratchBits::encode(scratch_.code()); 1083 ScratchBits::encode(scratch_.code());
1086 } 1084 }
1087 }; 1085 };
1088 1086
1089 1087
1090 } } // namespace v8::internal 1088 } } // namespace v8::internal
1091 1089
1092 #endif // V8_X64_CODEGEN_X64_H_ 1090 #endif // V8_X64_CODEGEN_X64_H_
OLDNEW
« no previous file with comments | « src/ia32/codegen-ia32.cc ('k') | src/x64/codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698