Issue 3026013: Fix compile by using FRIEND_TEST_ALL_PREFIXES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3026013: Fix compile by using FRIEND_TEST_ALL_PREFIXES. (Closed)

Created:
10 years, 5 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
gavinp

CC:
chromium-reviews, ben+cc_chromium.org, brettw-cc_chromium.org

Visibility:
Public.

Description

Fix compile by using FRIEND_TEST_ALL_PREFIXES. TBR=dhollowa Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53212

Patch Set 1 #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -9 lines)			Patch
	M	chrome/browser/history/top_sites.h	View		2 chunks	+10 lines, -9 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

gavinp

Drive by review... Didn't this CL break the build? http://codereview.chromium.org/3026013/diff/1/2 File chrome/browser/history/top_sites.h (right): http://codereview.chromium.org/3026013/diff/1/2#newcode112 chrome/browser/history/top_sites.h:112: ...

10 years, 5 months ago (2010-07-23 00:11:29 UTC) #1

Paweł Hajdan Jr.

I don't get the drive-by review. Could you explain?

10 years, 5 months ago (2010-07-23 00:26:43 UTC) #2

gavinp

10 years, 5 months ago (2010-07-23 00:35:37 UTC) #3

Sorry if I was too brief Paweł!

I happened to have the bad luck to check out exactly the wrong version of
Chrome, and my build broke at top_sites_unittest.cc.  The change you made to
top-sites got the name of the test in top_sites_unittest.cc wrong: the test is
named Migration, not MigrationTest.  My comment here was about that.

However, I've since updated, and checked, and you saw this and fixed it in a
checkout shortly after (r53213) , and in a review at
http://codereview.chromium.org/3026014.  Thanks.

Expand Messages | Collapse Messages