Download code cleanup:

Download code cleanup:

Changed the code to be more object-oriented. Instead of exposing 150 accessors
we should do as much as possible inside the object, exposing a nice API.
DownloadFile just got a small step closer to that.

Also, reduce amount of state duplication. For example, information about
the download progress was both in DownloadFile and DownloadFileManager
(maybe it's still somewhere else). The download path information
is still duplicated, removing it is going to be harder.

Finally, removed completely unused state variables from DownloadFile.

TEST=unit_tests, browser_tests, ui_tests
BUG=48913
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53217

[darin (slow to review), 2010-07-21 04:44:02]

LGTM

http://codereview.chromium.org/3026012/diff/1/3
File chrome/browser/download/download_file.h (right):

http://codereview.chromium.org/3026012/diff/1/3#newcode21
chrome/browser/download/download_file.h:21: class ResourceDispatcherHost;
it would be nice if we limited the number of classes that needed to know about
ResourceDispatcherHost.  i see that you are just passing it through, so this is
fine, but we should think about ways to minimize dependencies on RDH.  doing so
should help make the code less spaghetti like.