Issue 3025009: Revert 53198 - Some first run fixes:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3025009: Revert 53198 - Some first run fixes:... (Closed)

Created:
10 years, 5 months ago by Miranda Callahan

Modified:
9 years, 7 months ago

Reviewers:
mirandac

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 53198 - Some first run fixes: Add missing first run bubble back to opening page. Wait for search engines to load before displaying first run bubble, so correct search engine is displayed in first run. Because some distributions use "skip-first-run-ui", add back the "import_items" code that passes values to this code path. Because this code path is obsolete (most import is silent), this needs to be refactored in the long term. Fix some spelling issues. BUG=42612 TEST= import with --skip-first-run-ui works Review URL: http://codereview.chromium.org/3042010 TBR=mirandac@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53211

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -75 lines)			Patch
M	chrome/browser/first_run_win.cc	View	7 chunks	+50 lines, -44 lines	0 comments	Download
M	chrome/browser/views/location_bar/location_bar_view.h	View	5 chunks	+6 lines, -11 lines	0 comments	Download
M	chrome/browser/views/location_bar/location_bar_view.cc	View	4 chunks	+5 lines, -20 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages