Issue 3024001: Fix presubmit errors in test-heap-profiler.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3024001: Fix presubmit errors in test-heap-profiler.cc (Closed)

Created:
10 years, 5 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Fix presubmit errors in test-heap-profiler.cc I tried adding CheckNonEqualsHelper for int64_t, but this causes another avalanche of function resolving ambuguities. So, I ended up fooling linter. TBR=ager@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=5081

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -6 lines)			Patch
	M	test/cctest/test-heap-profiler.cc	View		3 chunks	+11 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

OK, LGTM

Expand Messages | Collapse Messages