Issue 3023040: Widen one suppression (bug 40429), fix styling nits in two other suppressions...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3023040: Widen one suppression (bug 40429), fix styling nits in two other suppressions... (Closed)

Created:
10 years, 4 months ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Widen one suppression (bug 40429), fix styling nits in two other suppressions BUG=40429, 31634 TBR=jrg,ajwong,oshima Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55057

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tools/valgrind/memcheck/suppressions_mac.txt	View		4 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

John Grabowski

10 years, 4 months ago (2010-08-06 20:03:02 UTC) #2

LGTM

If we need to keep playing this game here let me know and I'll try and do a code
change to avoid the problem (as mentioned in the comments).