Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1555)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3023039: Disable EULA/update/register screens for non-official builds. (Closed)

Created:
10 years, 4 months ago by Nikita (slow)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org, Paweł Hajdan Jr.
Base URL:
git://codf21.jail/chromium.git
Visibility:
Public.

Description

Disable EULA/update/register screens for non-official builds. BUG= http://crosbug.com/4646 TEST=Manual. These screens should not be shown on dev builds. Testing accelerators still work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55068

Patch Set 1 #

Patch Set 2 : merge #

Total comments: 2

Patch Set 3 : OOBE progress & fix test #

Patch Set 4 : test change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -6 lines) Patch
M chrome/browser/chromeos/login/background_view.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/background_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 2 3 6 chunks +23 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nikita (slow)
10 years, 4 months ago (2010-08-04 16:42:06 UTC) #1
Dmitry Polukhin
http://codereview.chromium.org/3023039/diff/2001/3001 File chrome/browser/chromeos/login/wizard_controller.cc (right): http://codereview.chromium.org/3023039/diff/2001/3001#newcode497 chrome/browser/chromeos/login/wizard_controller.cc:497: #if defined(OFFICIAL_BUILD) I think it may sense to remove ...
10 years, 4 months ago (2010-08-05 07:09:46 UTC) #2
Nikita (slow)
http://codereview.chromium.org/3023039/diff/2001/3001 File chrome/browser/chromeos/login/wizard_controller.cc (right): http://codereview.chromium.org/3023039/diff/2001/3001#newcode497 chrome/browser/chromeos/login/wizard_controller.cc:497: #if defined(OFFICIAL_BUILD) On 2010/08/05 07:09:47, Dmitry Polukhin wrote: > ...
10 years, 4 months ago (2010-08-05 14:20:39 UTC) #3
Dmitry Polukhin
10 years, 4 months ago (2010-08-05 14:23:47 UTC) #4 
LGTM

Powered by Google App Engine
This is Rietveld 408576698