Issue 3023025: NaCl: Fix link time error when DISABLE_NACL is set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3023025: NaCl: Fix link time error when DISABLE_NACL is set (Closed)

Created:
10 years, 4 months ago by Mark Seaborn

Modified:
9 years, 5 months ago

Reviewers:
Alexander Potapenko, Mark Schneckloth

CC:
chromium-reviews, native-client-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

NaCl: Fix link time error when DISABLE_NACL is set This fixes breakage on the ARM buildbot, introduced by r54113. nacl::Close() is not available when DISABLE_NACL is set. The error was: nacl_process_host.cc: error: undefined reference to 'nacl::Close(int)' BUG=none TEST=none (no trybot for the ARM build) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54123

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome/browser/nacl_host/nacl_process_host.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

On 2010/07/29 12:49:29, Mark Seaborn wrote: > I don't understand the details, but this should ...

10 years, 4 months ago (2010-07-29 12:51:43 UTC) #2

LGTM

Expand Messages | Collapse Messages