Issue 3023023: [Mac] Fix the custom homepages preferences.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3023023: [Mac] Fix the custom homepages preferences. (Closed)

Created:
10 years, 4 months ago by Robert Sesek

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

[Mac] Fix the custom homepages preferences to: 1) Make it actually work again. 2) Change the model so that it doesn't get into an infinite recursion cycle trying to update the model, notify observers, and then re-update. BUG=49320 TEST=Chromium-->Preferences. Add custom home pages. Close Preferences and reopen. They are still there. TEST=Open 3 web pages in tabs. Chromium-->Preferences. Use Current homepages. Close Preferences and reopen. They are still there. TEST=With custom homepages set, go to Chromium-->Preferences-->UtH-->Reset to Defaults. Go back to Basics. No more custom homepages. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53961

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+111 lines, -36 lines)			Patch
M	chrome/browser/cocoa/custom_home_pages_model.h	View	4 chunks	+28 lines, -3 lines	0 comments	Download
M	chrome/browser/cocoa/custom_home_pages_model.mm	View	5 chunks	+24 lines, -16 lines	1 comment	Download
M	chrome/browser/cocoa/custom_home_pages_model_unittest.mm	View	4 chunks	+58 lines, -14 lines	0 comments	Download
M	chrome/browser/cocoa/preferences_window_controller.mm	View	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

10 years, 4 months ago (2010-07-28 14:49:18 UTC) #2

lgtm, thanks for writing a test!

http://codereview.chromium.org/3023023/diff/1/3
File chrome/browser/cocoa/custom_home_pages_model.mm (right):

http://codereview.chromium.org/3023023/diff/1/3#newcode69
chrome/browser/cocoa/custom_home_pages_model.mm:69: // Converts the C++ URLs to
Cocoa objects without notifying KVO.
Should you explain why you don't want to notify kvo?

Expand Messages | Collapse Messages