Issue 3023001: Remove unnecessary formatting differences between ia32 and x64 code generator...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3023001: Remove unnecessary formatting differences between ia32 and x64 code generator... (Closed)

Created:
10 years, 5 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Remove unnecessary formatting differences between ia32 and x64 code generators. Mainly just typographical changes. Committed: http://code.google.com/p/v8/source/detail?r=5080

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -59 lines)			Patch
	M	src/ia32/codegen-ia32.cc	View	1	20 chunks	+34 lines, -32 lines	0 comments	Download
	M	src/x64/codegen-x64.cc	View	1	30 chunks	+43 lines, -27 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

10 years, 5 months ago (2010-07-15 13:29:12 UTC) #2

LGTM

http://codereview.chromium.org/3023001/diff/1/2
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/3023001/diff/1/2#newcode182
src/ia32/codegen-ia32.cc:182: loop_nesting_ += info->loop_nesting();
+= here is confusing IMHO.

Consider changing it to = in both codegens.

Expand Messages | Collapse Messages