Create common script file for workon tools. Planning on using in another CL.

Create common script file for workon tools.  Planning on using in another CL.

[anush, 2010-07-19 18:13:42]

Can you add it to the lib/ directory since it will be installed in the
chroot?

Thanks

On Mon, Jul 19, 2010 at 11:07 AM, <sosa@chromium.org> wrote:

> Reviewers: Mandeep Singh Baines, zbehan,
>
> Description:
> Create common script file for workon tools.  Planning on using in another
> CL.
>
> Please review this at http://codereview.chromium.org/3022010/show
>
> SVN Base: ssh://git@chromiumos-git//crosutils.git
>
> Affected files:
>  M cros_workon
>  A cros_workon_common.sh
>
>
> Index: cros_workon
> diff --git a/cros_workon b/cros_workon
> index
>
fc9d6d15cf19087faac887d69c72b907d8846ad0..b8c39a42c9fbacfaf38e433e7302da01c5a8d953
> 100755
> --- a/cros_workon
> +++ b/cros_workon
> @@ -14,6 +14,9 @@
>  # The path to common.sh should be relative to your script's location.
>  . "$(dirname "$0")/common.sh"
>
> +# Load common functions for workon scripts.
> +. "$(dirname "$0")/cros_workon_common.sh"
> +
>  # Script must be run inside the chroot
>  restart_in_chroot_if_needed $*
>  get_default_board
> @@ -154,20 +157,6 @@ ebuild_forall() {
>   done
>  }
>
> -show_workon_ebuilds() {
> -  pushd "${BOARD_DIR}"/etc/ 1> /dev/null
> -  source make.conf
> -  popd 1> /dev/null
> -  local CROS_OVERLAYS="${PORTDIR_OVERLAY}"
> -
> -  for overlay in ${CROS_OVERLAYS}; do
> -    pushd ${overlay} 1> /dev/null
> -    find . -name '*.ebuild' | xargs fgrep cros-workon | \
> -      awk -F / '{ print $2 "/" $3 }' | uniq | sort
> -    popd 1> /dev/null
> -  done
> -}
> -
>  # --all makes commands operate on different lists
>  if [ ${FLAGS_all} = "${FLAGS_TRUE}" ]; then
>   case ${WORKON_CMD} in
> Index: cros_workon_common.sh
> diff --git a/cros_workon_common.sh b/cros_workon_common.sh
> new file mode 100644
> index
>
0000000000000000000000000000000000000000..45f3c1370311f237f3d2373abbd632e23e998211
> --- /dev/null
> +++ b/cros_workon_common.sh
> @@ -0,0 +1,21 @@
> +#!/bin/bash
> +
> +# Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
> +# Use of this source code is governed by a BSD-style license that can be
> +# found in the LICENSE file.
> +
> +# Common library for functions used by workon tools.
> +
> +show_workon_ebuilds() {
> +  pushd "${BOARD_DIR}"/etc/ 1> /dev/null
> +  source make.conf
> +  popd 1> /dev/null
> +  local CROS_OVERLAYS="${PORTDIR_OVERLAY}"
> +
> +  for overlay in ${CROS_OVERLAYS}; do
> +    pushd ${overlay} 1> /dev/null
> +    find . -name '*.ebuild' | xargs fgrep cros-workon | \
> +      awk -F / '{ print $2 "/" $3 }' | uniq | sort
> +    popd 1> /dev/null
> +  done
> +}
>
>
>

[sosa, 2010-07-19 18:21:52]

Done.

[Mandeep Singh Baines, 2010-07-19 18:41:27]

LGTM