omaha_response_handler_action.cc - Issue 3022008: For actions, switch bool success into an exit code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: omaha_response_handler_action.cc

Issue 3022008: For actions, switch bool success into an exit code. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/update_engine.git

Patch Set: switch to all positive error codes. Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: omaha_response_handler_action.cc

diff --git a/omaha_response_handler_action.cc b/omaha_response_handler_action.cc

index d93919a1bfde82a8590c8afd481d39b00049db34..75776abe6c5dd83dc26bc54d0cd31c4decbdc18e 100644

--- a/omaha_response_handler_action.cc

+++ b/omaha_response_handler_action.cc

@@ -43,7 +43,7 @@ void OmahaResponseHandlerAction::PerformAction() {

LOG(INFO) << "Using this install plan:";

install_plan_.Dump();

- completer.set_success(true);

+ completer.set_code(kActionCodeSuccess);

}

bool OmahaResponseHandlerAction::GetInstallDev(const std::string& boot_dev,

« no previous file with comments | « omaha_request_action_unittest.cc ('k') | omaha_response_handler_action_unittest.cc » ('j') | no next file with comments »