Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2447)

Unified Diff: action_processor.cc

Issue 3022008: For actions, switch bool success into an exit code. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/update_engine.git
Patch Set: switch to all positive error codes. Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « action_processor.h ('k') | action_processor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: action_processor.cc
diff --git a/action_processor.cc b/action_processor.cc
index e52cbcdc1482b2552f730983f934b6e28274ffb3..0d8c046a9105e89c0432f9ff28c9baf5ae8bece7 100644
--- a/action_processor.cc
+++ b/action_processor.cc
@@ -54,17 +54,17 @@ void ActionProcessor::StopProcessing() {
}
void ActionProcessor::ActionComplete(AbstractAction* actionptr,
- bool success) {
+ ActionExitCode code) {
CHECK_EQ(actionptr, current_action_);
if (delegate_)
- delegate_->ActionCompleted(this, actionptr, success);
+ delegate_->ActionCompleted(this, actionptr, code);
string old_type = current_action_->Type();
current_action_->SetProcessor(NULL);
current_action_ = NULL;
if (actions_.empty()) {
LOG(INFO) << "ActionProcessor::ActionComplete: finished last action of"
" type " << old_type;
- } else if (!success) {
+ } else if (code != kActionCodeSuccess) {
LOG(INFO) << "ActionProcessor::ActionComplete: " << old_type
<< " action failed. Aborting processing.";
actions_.clear();
@@ -73,7 +73,7 @@ void ActionProcessor::ActionComplete(AbstractAction* actionptr,
LOG(INFO) << "ActionProcessor::ActionComplete: finished last action of"
" type " << old_type;
if (delegate_) {
- delegate_->ProcessingDone(this, success);
+ delegate_->ProcessingDone(this, code);
}
return;
}
« no previous file with comments | « action_processor.h ('k') | action_processor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698