Issue 3021004: Heapchecker: Update the signature for a family of leaks....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3021004: Heapchecker: Update the signature for a family of leaks.... (Closed)

Created:
10 years, 5 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, pam+watch_chromium.org, erikchen

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Heapchecker: Update the signature for a family of leaks. BUG=46886 TEST=Heapchecker net gets greener. TBR=glider Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52818

Patch Set 1 #

Total comments: 2

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/heapcheck/suppressions.txt	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

http://codereview.chromium.org/3021004/diff/1/2 File tools/heapcheck/suppressions.txt (right): http://codereview.chromium.org/3021004/diff/1/2#newcode767 tools/heapcheck/suppressions.txt:767: fun:*SpdyHttpStreamTest_SendRequest_Test Didn't you miss a wildcard, i.e. "fun:*SpdyHttpStreamTest_SendRequest_Test*"?

10 years, 5 months ago (2010-07-17 12:26:43 UTC) #2

Lei Zhang

10 years, 5 months ago (2010-07-19 18:28:19 UTC) #3

http://codereview.chromium.org/3021004/diff/1/2
File tools/heapcheck/suppressions.txt (right):

http://codereview.chromium.org/3021004/diff/1/2#newcode767
tools/heapcheck/suppressions.txt:767: fun:*SpdyHttpStreamTest_SendRequest_Test
On 2010/07/17 12:26:43, Alexander Potapenko wrote:
> Didn't you miss a wildcard, i.e. "fun:*SpdyHttpStreamTest_SendRequest_Test*"?

Ya, I saw fun:*SpdyHttpStreamTest_SendRequest_Test::TestBody on a valgrind run
the next day but didn't get around to fixing it.

Expand Messages | Collapse Messages