Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 3021004: Heapchecker: Update the signature for a family of leaks.... (Closed)

Created:
10 years, 5 months ago by Lei Zhang
Modified:
9 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org, erikchen
Visibility:
Public.

Description

Heapchecker: Update the signature for a family of leaks. BUG=46886 TEST=Heapchecker net gets greener. TBR=glider Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52818

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/heapcheck/suppressions.txt View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
From r52670?
10 years, 5 months ago (2010-07-17 09:47:34 UTC) #1
Alexander Potapenko
http://codereview.chromium.org/3021004/diff/1/2 File tools/heapcheck/suppressions.txt (right): http://codereview.chromium.org/3021004/diff/1/2#newcode767 tools/heapcheck/suppressions.txt:767: fun:*SpdyHttpStreamTest_SendRequest_Test Didn't you miss a wildcard, i.e. "fun:*SpdyHttpStreamTest_SendRequest_Test*"?
10 years, 5 months ago (2010-07-17 12:26:43 UTC) #2
Lei Zhang
10 years, 5 months ago (2010-07-19 18:28:19 UTC) #3
http://codereview.chromium.org/3021004/diff/1/2
File tools/heapcheck/suppressions.txt (right):

http://codereview.chromium.org/3021004/diff/1/2#newcode767
tools/heapcheck/suppressions.txt:767: fun:*SpdyHttpStreamTest_SendRequest_Test
On 2010/07/17 12:26:43, Alexander Potapenko wrote:
> Didn't you miss a wildcard, i.e. "fun:*SpdyHttpStreamTest_SendRequest_Test*"?

Ya, I saw fun:*SpdyHttpStreamTest_SendRequest_Test::TestBody on a valgrind run
the next day but didn't get around to fixing it.

Powered by Google App Engine
This is Rietveld 408576698