Issue 3021003: AU: minor fixes requested in http://codereview.chromium.org/3010009

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3021003: AU: minor fixes requested in http://codereview.chromium.org/3010009 (Closed)

Created:
10 years, 5 months ago by adlr

Modified:
9 years ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/update_engine.git

Visibility:
Public.

Description

AU: minor fixes requested in http://codereview.chromium.org/3010009 These were too minor to fix at the time, since the CL was needed urgently.

Patch Set 1 #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -10 lines)			Patch
	M	libcurl_http_fetcher.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	libcurl_http_fetcher.cc	View		4 chunks	+5 lines, -9 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

10 years, 5 months ago (2010-07-17 04:32:43 UTC) #2

LGTM

http://codereview.chromium.org/3021003/diff/1/2
File libcurl_http_fetcher.cc (right):

http://codereview.chromium.org/3021003/diff/1/2#newcode260
libcurl_http_fetcher.cc:260: // We always return true, even if we don't want
glib to cll us back.
typo: cll

Expand Messages | Collapse Messages