Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1773)

Unified Diff: chrome/browser/external_tab_container_win.cc

Issue 3021002: In ChromeFrame if window.open is received for a pending external tab, i.e. wh... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/external_tab_container_win.cc
===================================================================
--- chrome/browser/external_tab_container_win.cc (revision 52523)
+++ chrome/browser/external_tab_container_win.cc (working copy)
@@ -333,7 +333,12 @@
WindowOpenDisposition disposition,
const gfx::Rect& initial_pos,
bool user_gesture) {
- DCHECK(automation_ != NULL);
+ if (!automation_) {
+ DCHECK(pending_);
+ LOG(ERROR) << "Invalid automation provider. Dropping new contents notify";
+ delete new_contents;
amit 2010/07/16 22:25:38 we might have to do other cleanup corresponding to
+ return;
+ }
scoped_refptr<ExternalTabContainer> new_container =
new ExternalTabContainer(NULL, NULL);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698