Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 3020077: Revert 55405 - Special thanks for in-ming cheng's MFT hardware decodering cod... (Closed)

Created:
10 years, 4 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
jiesun1
CC:
chromium-reviews, fbarchard, Alpha Left Google, ben+cc_chromium.org, jam, apatrick_chromium, darin-cc_chromium.org, awong, brettw-cc_chromium.org, scherkus (not reviewing)
Visibility:
Public.

Description

Revert 55405 - Special thanks for in-ming cheng's MFT hardware decodering code. 1. ipc_video_decoder.cc/h is media pipeline filter which use the gpu decoder facilities in video stack. it is only enabled when (a) hardware composition is on (b) hardware decoding command line is on (c) h264 codec is specified. 2. gpu_video_service.cc/h is a singleton in gpu process which provide video services for renderer process, through it we could create decoder. ( in my imagination, in the future, we could create encoder or capturer too) 3. gpu_video_decoder.cc/h. abstract interface for hardware decoder. 4. gpu_video_decoder_mft.cc/h media foundation transform hardware decoder which run on windows 7 only. 5. gpu_video_service_host.cc/h is singleton in renderer process which provide proxy for gpu_video_service. 6. gpu_video_decoder_host.cc/h is proxy for gpu_video_decoder. (1 to 1 map).basically there is one global GpuVideoService in GPU process, one GpuVideoServiceHost in Renderer process. for each renderer process, there are could be multiple renderer view, each could had multiple GpuVideoDecoderHost the connect to GpuVideoDeocder through GPUCHannelHOst/GpuChannel. 7. gpu_video_common.cc/h: IPC message definition and pickle/marshaling support. ISSUES: 1. in media pipeline, we need let decoder to determine if bit stream filter should be used instead of let command line to determine it. 2. stop readback from D3D surface use ANGLE. 3. Flush logic still need fine tuning. 4. CreateThread in GpuVideoDecoder, and post message in message handler, and derived classs handle message loop. ? 5. Error handling. 6. Input ring buffer implementation. Current impl is naive. 7.Add output queue for MFT decoder. 8. Query Capabilities at GetVideoServices()... BUG=None TEST=Windows7 Review URL: http://codereview.chromium.org/2873089 TBR=jiesun@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55419

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2481 lines) Patch
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_renderer.gypi View 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/common/gpu_messages_internal.h View 3 chunks +0 lines, -80 lines 0 comments Download
D chrome/common/gpu_video_common.h View 1 chunk +0 lines, -172 lines 0 comments Download
D chrome/common/gpu_video_common.cc View 1 chunk +0 lines, -211 lines 0 comments Download
M chrome/gpu/gpu_channel.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/gpu/gpu_channel.cc View 4 chunks +0 lines, -52 lines 0 comments Download
D chrome/gpu/gpu_video_decoder.h View 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/gpu/gpu_video_decoder.cc View 1 chunk +0 lines, -108 lines 0 comments Download
D chrome/gpu/gpu_video_decoder_mft.h View 1 chunk +0 lines, -98 lines 0 comments Download
D chrome/gpu/gpu_video_decoder_mft.cc View 1 chunk +0 lines, -594 lines 0 comments Download
D chrome/gpu/gpu_video_service.h View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/gpu/gpu_video_service.cc View 1 chunk +0 lines, -76 lines 0 comments Download
M chrome/renderer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/gpu_channel_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/gpu_channel_host.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D chrome/renderer/gpu_video_decoder_host.h View 1 chunk +0 lines, -126 lines 0 comments Download
D chrome/renderer/gpu_video_decoder_host.cc View 1 chunk +0 lines, -199 lines 0 comments Download
D chrome/renderer/gpu_video_service_host.h View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/renderer/gpu_video_service_host.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D chrome/renderer/media/ipc_video_decoder.h View 1 chunk +0 lines, -100 lines 0 comments Download
D chrome/renderer/media/ipc_video_decoder.cc View 1 chunk +0 lines, -344 lines 0 comments Download
M chrome/renderer/render_thread.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/renderer/render_view.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M ipc/ipc_message_utils.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/media_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/media_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
ananta
10 years, 4 months ago (2010-08-09 17:58:43 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698