Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 3020068: WebSocket over SPDY. (Closed)

Created:
10 years, 4 months ago by ukai
Modified:
6 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Work in progress: WebSocket over SPDY. WebSocket would use SpdySession opened for the same host:port if any. BUG=42320 TEST=net_unittests passes

Patch Set 1 #

Total comments: 22

Patch Set 2 : update #

Patch Set 3 : fix WebSocketThrottle test #

Patch Set 4 : rebase #

Patch Set 5 : fix unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+930 lines, -20 lines) Patch
M net/net.gyp View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M net/socket_stream/socket_stream.h View 1 2 3 4 6 chunks +12 lines, -0 lines 0 comments Download
M net/socket_stream/socket_stream.cc View 1 2 3 4 5 chunks +32 lines, -0 lines 0 comments Download
M net/spdy/spdy_framer.h View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M net/spdy/spdy_stream.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M net/spdy/spdy_stream.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
A net/spdy/spdy_websocket_stream.h View 1 2 3 4 1 chunk +96 lines, -0 lines 0 comments Download
A net/spdy/spdy_websocket_stream.cc View 1 2 3 4 1 chunk +141 lines, -0 lines 0 comments Download
A net/spdy/spdy_websocket_stream_unittest.cc View 1 2 3 4 1 chunk +433 lines, -0 lines 0 comments Download
M net/websockets/websocket_job.h View 1 5 chunks +27 lines, -2 lines 0 comments Download
M net/websockets/websocket_job.cc View 1 2 3 4 9 chunks +165 lines, -18 lines 0 comments Download
M net/websockets/websocket_throttle_unittest.cc View 1 2 3 4 11 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ukai
10 years, 4 months ago (2010-08-05 11:41:39 UTC) #1
Paweł Hajdan Jr.
Drive-by with a minor test comment. No need to wait for another review by me. ...
10 years, 4 months ago (2010-08-05 17:24:50 UTC) #2
Mike Belshe
http://codereview.chromium.org/3020068/diff/1/3 File net/socket_stream/socket_stream.cc (right): http://codereview.chromium.org/3020068/diff/1/3#newcode6 net/socket_stream/socket_stream.cc:6: // think about ways to share code, if possible. ...
10 years, 4 months ago (2010-08-05 17:26:23 UTC) #3
ukai
http://codereview.chromium.org/3020068/diff/1/3 File net/socket_stream/socket_stream.cc (right): http://codereview.chromium.org/3020068/diff/1/3#newcode6 net/socket_stream/socket_stream.cc:6: // think about ways to share code, if possible. ...
10 years, 4 months ago (2010-08-09 10:08:46 UTC) #4
ukai
Sorry for long idle. I'd like to back working on this, with Toyoshima-san. I've updated ...
10 years ago (2010-12-07 05:44:53 UTC) #5
mbelshe
Hi, Ukai - Do you want me to take a look at this now? Mike ...
10 years ago (2010-12-07 16:49:03 UTC) #6
ukai
10 years ago (2010-12-08 01:56:29 UTC) #7
On 2010/12/07 16:49:03, mbelshe wrote:
> Hi, Ukai -
> 
> Do you want me to take a look at this now?

It's ok to review it later.
Please take a look when you have time.

Thanks!

> 
> Mike
> 
> 
> 
> On Mon, Dec 6, 2010 at 9:44 PM, <mailto:ukai@chromium.org> wrote:
> 
> > Sorry for long idle.
> > I'd like to back working on this, with Toyoshima-san.
> > I've updated this CL to follow spdy's change.
> >
> > BTW, WebSocket protocol (handshake, framing) will change soon, so we'll
> > need to
> > follow that change.  I'm not sure we'll land it soon and update later, or
> > wait
> > for websocket protocol updates.
> >
> > Anyway, I'd like to share this CL with Toyoshima-san now.
> >
> > http://codereview.chromium.org/3020068/
> >

Powered by Google App Engine
This is Rietveld 408576698