Issue 3020037: Run mod_image_for_recovery.sh to create recovery image.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3020037: Run mod_image_for_recovery.sh to create recovery image. (Closed)

Created:
10 years, 5 months ago by djmm

Modified:
9 years, 7 months ago

Reviewers:
Nick Sanders, Tan Gao, adlr

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@chromiumos-git/crosutils.git

Visibility:
Public.

Description

Add do_recovery_mod() to create recovery image

Patch Set 4 : foobar #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	archive_build.sh	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nick Sanders

lgtm, w/ format change tgao should confirm that this is right as well though. http://codereview.chromium.org/3020037/diff/1/2 ...

10 years, 4 months ago (2010-07-28 19:29:07 UTC) #3

Tan Gao

http://codereview.chromium.org/3020037/diff/1/2 File archive_build.sh (right): http://codereview.chromium.org/3020037/diff/1/2#newcode138 archive_build.sh:138: OUTPUT_IMAGE=$2 currently, mod_image_for_recovery.sh creates a hard-coded recovery image named ...

10 years, 4 months ago (2010-07-28 20:03:41 UTC) #4

Tan Gao

10 years, 4 months ago (2010-07-29 04:00:40 UTC) #6

LGTM

resulting image will be created in the SAME directory as the base image with
filename "recovery_image.bin"

Expand Messages | Collapse Messages

Issue 3020037: Run mod_image_for_recovery.sh to create recovery image. (Closed)

Description

Patch Set 1 #

Patch Set 2 : foobar #

Patch Set 3 : foobar #

Patch Set 4 : foobar #

Messages