Issue 3020035: Mac: Add "Show Tab Overview" menu item.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3020035: Mac: Add "Show Tab Overview" menu item. (Closed)

Created:
10 years, 5 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, ben+cc_chromium.org, John Grabowski, pam+watch_chromium.org

Visibility:
Public.

Description

Mac: Add "Show Tab Overview" menu item. xib changes: Add menu item with shortcut cmd-f10 for now, connect it to -commandDispatch:. Connect app controller's new outlet to the new menu item. BUG=50307 TEST=No changes by default. If --enable-expose-for-tabs is passed, a new menu item should be visible below "prev tab" in the window menu. It should be active for normal browser windows and fullscreen windows, but not if there are no browser windows around or if the current window is a popup window or a non-browser window (e.g. prefs). Clicking the menu item doesn't do anything yet. cmd-f10 should trigger the menu item, but it shouldn't if the cmdline flag isn't passed. TEST2=Go to a page that is busy spinning some javascript (e.g. "javascript:while(1);"), give it focus, hit cmd-f10. Menu should blink immediately. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53833

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+222 lines, -6 lines)			Patch
M	chrome/app/chrome_dll_resource.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/app/nibs/MainMenu.xib	View	2	18 chunks	+207 lines, -6 lines	0 comments	Download
M	chrome/browser/app_controller_mac.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/app_controller_mac.mm	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/browser.cc	View	1 2 3	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages

Issue 3020035: Mac: Add "Show Tab Overview" menu item. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : javascript #

Messages