Issue 3020034: Mac: Add flag for expose-for-tabs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3020034: Mac: Add flag for expose-for-tabs (Closed)

Created:
10 years, 4 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews

Visibility:
Public.

Description

Mac: Add flag for expose-for-tabs BUG=50307 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53798

Patch Set 3 : comments #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	chrome/common/chrome_switches.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/common/chrome_switches.cc	View	1 2	1 chunk	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

LGTM with nits. http://codereview.chromium.org/3020034/diff/3001/4001 File chrome/common/chrome_switches.cc (right): http://codereview.chromium.org/3020034/diff/3001/4001#newcode1089 chrome/common/chrome_switches.cc:1089: const char kEnableExposeForTabs[] = "enable-expose-for-tabs"; Same. ...

10 years, 4 months ago (2010-07-27 16:59:40 UTC) #2

Nico

http://codereview.chromium.org/3020034/diff/3001/4002 File chrome/common/chrome_switches.h (right): http://codereview.chromium.org/3020034/diff/3001/4002#newcode329 chrome/common/chrome_switches.h:329: extern const char kEnableExposeForTabs[]; On 2010/07/27 16:59:40, rsesek wrote: ...

10 years, 4 months ago (2010-07-27 17:02:15 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 3020034: Mac: Add flag for expose-for-tabs (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : comments #

Messages