Fixes errors when loading animated meshes in simpleviewer....

o3d-webgl: Fixes errors when loading animated meshes in simpleviewer.

Use setUpO3DParam_ instead of createParam so that the "o3d." names can be used by serialization.js;
simpleviewer calls Pack.destroy which can fail.
Implement o3d.Matrix4Composition.
Typos in curve loading.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53985

[petersont, 2010-07-27 22:26:33]

http://codereview.chromium.org/3020030/diff/3001/4002
File samples/o3d-webgl/function.js (right):

http://codereview.chromium.org/3020030/diff/3001/4002#newcode114
samples/o3d-webgl/function.js:114:
o3d.ParamObject.setUpO3DParam_(o3d.FunctionEval, "output", "ParamFloatOutput");
This looks much cleaner.  I like it.

http://codereview.chromium.org/3020030/diff/3001/4003
File samples/o3d-webgl/pack.js (right):

http://codereview.chromium.org/3020030/diff/3001/4003#newcode76
samples/o3d-webgl/pack.js:76: if (this.client.removePack) {
I'm not sure why you needed to add this, but it seems like a reasonable thing to
do.  Do you see any reason to make it:  if (this.client &&
this.client.removePack) ?

http://codereview.chromium.org/3020030/diff/3001/4004
File samples/o3d-webgl/param_operation.js (right):

http://codereview.chromium.org/3020030/diff/3001/4004#newcode360
samples/o3d-webgl/param_operation.js:360: * @return {Array<Array<number>>} 4x4
array equal to
I think this wants to be {!Array.<!Array.<number>>}

The ! indicates that it is to be non-null.

[Patrick Horn, 2010-07-28 00:05:43]

http://codereview.chromium.org/3020030/diff/3001/4003
File samples/o3d-webgl/pack.js (right):

http://codereview.chromium.org/3020030/diff/3001/4003#newcode76
samples/o3d-webgl/pack.js:76: if (this.client.removePack) {
On 2010/07/27 22:26:33, petersont wrote:
> I'm not sure why you needed to add this, but it seems like a reasonable thing
to
> do.  Do you see any reason to make it:  if (this.client &&
> this.client.removePack) ?

I ran into an error here when typing another mesh name into the text box of
simpleviewer.html and clicking "load" after another mesh had been loaded.

http://codereview.chromium.org/3020030/diff/3001/4004
File samples/o3d-webgl/param_operation.js (right):

http://codereview.chromium.org/3020030/diff/3001/4004#newcode360
samples/o3d-webgl/param_operation.js:360: * @return {Array<Array<number>>} 4x4
array equal to
On 2010/07/27 22:26:33, petersont wrote:
> I think this wants to be {!Array.<!Array.<number>>}
> 
> The ! indicates that it is to be non-null.

Done here and other places in this file.

[luchen, 2010-07-28 00:15:28]

http://codereview.chromium.org/3020030/diff/11001/12002
File samples/o3d-webgl/function.js (right):

http://codereview.chromium.org/3020030/diff/11001/12002#newcode115
samples/o3d-webgl/function.js:115: 
Does using setupO3DParam also set up a Setter for the 'output' value? Any danger
that someone might use that setter inadvertently?

http://codereview.chromium.org/3020030/diff/11001/12003
File samples/o3d-webgl/pack.js (right):

http://codereview.chromium.org/3020030/diff/11001/12003#newcode76
samples/o3d-webgl/pack.js:76: if (this.client.removePack) {
Client.js doesn't seem to even have a removePack method... I think this might be
a typo/mistranslation? The C++ source calls destroyPack on the client.

[Patrick Horn, 2010-07-28 01:20:51]

http://codereview.chromium.org/3020030/diff/11001/12002
File samples/o3d-webgl/function.js (right):

http://codereview.chromium.org/3020030/diff/11001/12002#newcode115
samples/o3d-webgl/function.js:115: 
On 2010/07/28 00:15:28, luchen wrote:
> Does using setupO3DParam also set up a Setter for the 'output' value? Any
danger
> that someone might use that setter inadvertently?

That was my original reason for not using setUpO3DParam_. However, I ran into
trouble when loading meshes, and the setter should do nothing because
ParamFloatOutput doesn't allow for setting value.

http://codereview.chromium.org/3020030/diff/11001/12003
File samples/o3d-webgl/pack.js (right):

http://codereview.chromium.org/3020030/diff/11001/12003#newcode76
samples/o3d-webgl/pack.js:76: if (this.client.removePack) {
On 2010/07/28 00:15:28, luchen wrote:
> Client.js doesn't seem to even have a removePack method... I think this might
be
> a typo/mistranslation? The C++ source calls destroyPack on the client.

Done. This fixes the error when clicking load in simpleviewer.

[luchen, 2010-07-28 18:08:12]

LGTM, see my opinion on using >> in place of divide/floor in the other CL
though.