Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 3020021: DOMUI prefs: Add and wire up a stub overlay for adding a startup page. (Closed)

Created:
10 years, 5 months ago by stuartmorgan
Modified:
9 years, 7 months ago
CC:
chromium-reviews, dhg, ben+cc_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

DOMUI prefs: Add and wire up a stub overlay for adding a startup page. BUG=49090 TEST=The "Add..." button on the Basics page of DOMUI options should bring up an empty overlay. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53479

Patch Set 1 #

Patch Set 2 : Fix button labels #

Total comments: 4

Patch Set 3 : Addresses review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -11 lines) Patch
A chrome/browser/dom_ui/add_startup_page_handler.h View 1 chunk +24 lines, -0 lines 0 comments Download
A chrome/browser/dom_ui/add_startup_page_handler.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/options_ui.cc View 1 2 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/resources/options.html View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
A chrome/browser/resources/options/add_startup_page_overlay.html View 1 1 chunk +16 lines, -0 lines 0 comments Download
A chrome/browser/resources/options/add_startup_page_overlay.js View 1 chunk +31 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/browser_options.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/options_page.css View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
stuartmorgan
As we get more overlay dialogs we may want to look for a better way ...
10 years, 5 months ago (2010-07-22 18:59:38 UTC) #1
arv (Not doing code reviews)
LGTM http://codereview.chromium.org/3020021/diff/3001/4003 File chrome/browser/dom_ui/options_ui.cc (right): http://codereview.chromium.org/3020021/diff/3001/4003#newcode122 chrome/browser/dom_ui/options_ui.cc:122: AddOptionsPageUIHandler(localized_strings, new AddStartupPageHandler()); Keep in alphabetical order? http://codereview.chromium.org/3020021/diff/3001/4009 ...
10 years, 5 months ago (2010-07-22 22:00:29 UTC) #2
stuartmorgan
http://codereview.chromium.org/3020021/diff/3001/4003 File chrome/browser/dom_ui/options_ui.cc (right): http://codereview.chromium.org/3020021/diff/3001/4003#newcode122 chrome/browser/dom_ui/options_ui.cc:122: AddOptionsPageUIHandler(localized_strings, new AddStartupPageHandler()); On 2010/07/22 22:00:29, arv wrote: > ...
10 years, 5 months ago (2010-07-22 23:47:47 UTC) #3
zel
10 years, 5 months ago (2010-07-23 01:04:39 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698