Issue 3020008: Mac: Make TransportDIB::Create() work.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3020008: Mac: Make TransportDIB::Create() work. (Closed)

Created:
10 years, 5 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org

Visibility:
Public.

Description

Mac: Make TransportDIB::Create() work. This is never called from "live" code, but chrome/browser/tab_contents/thumbnail_generator.cc uses it. ThumbnailGenerator is currently used only on windows, but I'd like to use it on OS X. TransportDIB::Create() isn't called on OS X because all created by chrome/browser/renderer_host/render_widget_helper.cc, which creates only the shared memory object and stores it away. The actual TransportDIB is created by calls to TransportDIB::Map() in both browser and renderer processes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52835

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	app/surface/transport_dib_mac.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

Did you intend to say something? Looks like you sent an empty reply. On Jul ...

10 years, 5 months ago (2010-07-17 20:06:34 UTC) #3

agl

10 years, 5 months ago (2010-07-17 20:11:37 UTC) #4

On Sat, Jul 17, 2010 at 4:06 PM, Nico Weber <thakis@chromium.org> wrote:
> Did you intend to say something? Looks like you sent an empty reply.

Oh, sorry. LGTM :)

Expand Messages | Collapse Messages