Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 3020005: Move tests for the layout test plugin to the right fixture. (Closed)

Created:
10 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Move tests for the layout test plugin to the right fixture. BUG=30702 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52669

Patch Set 1 #

Patch Set 2 : fix instead of flaky #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -55 lines) Patch
M chrome/test/ui/layout_plugin_uitest.cc View 2 chunks +61 lines, -0 lines 0 comments Download
M chrome/test/ui/npapi_uitest.cc View 1 3 chunks +1 line, -55 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jochen (gone - plz use gerrit)
This test fails on my on a fresh build of Chrome w/o patches on Windows. ...
10 years, 5 months ago (2010-07-16 07:33:55 UTC) #1
Bernhard Bauer
On 2010/07/16 07:33:55, jochen wrote: > This test fails on my on a fresh build ...
10 years, 5 months ago (2010-07-16 09:42:56 UTC) #2
jochen (gone - plz use gerrit)
I had a closer look at it and it turns out these tests cannot ever ...
10 years, 5 months ago (2010-07-16 11:09:16 UTC) #3
Bernhard Bauer
On 2010/07/16 11:09:16, jochen wrote: > I had a closer look at it and it ...
10 years, 5 months ago (2010-07-16 11:58:38 UTC) #4
jochen (gone - plz use gerrit)
Evan, seems on Linux, the trybots can't load the layout plugin (the error is that ...
10 years, 5 months ago (2010-07-16 14:14:37 UTC) #5
Evan Martin
I didn't change this code recently -- why'd it break?
10 years, 5 months ago (2010-07-16 14:49:50 UTC) #6
jochen (gone - plz use gerrit)
On 2010/07/16 14:14:37, jochen wrote: > Evan, seems on Linux, the trybots can't load the ...
10 years, 5 months ago (2010-07-16 14:57:19 UTC) #7
jochen (gone - plz use gerrit)
10 years, 5 months ago (2010-07-16 15:40:11 UTC) #8
ok, when i compile statically on linux, it works. i've marked the
selfdeleteplugin test as flaky for now, because it doesn't work on linux
(shlib). I check on monday whether after r52657 this problem is fixed and enable
it again.

Powered by Google App Engine
This is Rietveld 408576698