Issue 3020003: StringDictionary::FindEntry optimized for symbol strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3020003: StringDictionary::FindEntry optimized for symbol strings. (Closed)

Created:
10 years, 5 months ago by SeRya

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

StringDictionary::FindEntry optimized for symbol strings. Committed: http://code.google.com/p/v8/source/detail?r=5086

Patch Set 3 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -1 line)			Patch
	M	src/objects.h	View	1 2	2 chunks	+5 lines, -1 line	0 comments	Download
	M	src/objects.cc	View	1 2	1 chunk	+40 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/3020003/diff/4001/5001 File src/objects.cc (right): http://codereview.chromium.org/3020003/diff/4001/5001#newcode7353 src/objects.cc:7353: // perform futher lookups in code stubs (and ...

10 years, 5 months ago (2010-07-16 09:57:27 UTC) #2

SeRya

10 years, 5 months ago (2010-07-16 10:07:24 UTC) #3

http://codereview.chromium.org/3020003/diff/4001/5001
File src/objects.cc (right):

http://codereview.chromium.org/3020003/diff/4001/5001#newcode7353
src/objects.cc:7353: //    perform futher lookups in code stubs (and significant
performance boost
On 2010/07/16 09:57:27, Mads Ager wrote:
> futher -> further.

Done.

http://codereview.chromium.org/3020003/diff/4001/5002
File src/objects.h (right):

http://codereview.chromium.org/3020003/diff/4001/5002#newcode2298
src/objects.h:2298: // Find entry for key otherwise return -1. Optimzed version
of
On 2010/07/16 09:57:27, Mads Ager wrote:
> -1 -> kNotFound

Done (fixed for both FindEntry).

Expand Messages | Collapse Messages

Issue 3020003: StringDictionary::FindEntry optimized for symbol strings. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages