Issue 3019024: revert r53268:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3019024: revert r53268: (Closed)

Created:
10 years, 5 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
tony

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

revert r53268: ------------------------------------ GTK: when closing a browser window, cancel the active drag session. This speculatively works around an issue where users' windows would get stuck open in rare (non-reproducible, but widely reported) cases. BUG=23733 TEST=none :( ------------------------------------- I thought I had fixed the issue where dragging out the last tab closed the window. Apparently not. BUG=50055 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53533

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -15 lines)			Patch
M	chrome/browser/gtk/browser_window_gtk.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/gtk/tabs/tab_strip_gtk.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/gtk/tabs/tab_strip_gtk.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

OK

Expand Messages | Collapse Messages