Issue 3019010: Fix the failing ChromeFrame BeginningTransaction unit test. The user agent va...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3019010: Fix the failing ChromeFrame BeginningTransaction unit test. The user agent va... (Closed)

Created:
10 years, 5 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
stoyan

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix the failing ChromeFrame BeginningTransaction unit test. The user agent value in the http headers needs to be terminated with a trailing \r\n\r\n combination instead of a single \r\n value. TBR=stoyan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52871

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome_frame/http_negotiate.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

stoyan

10 years, 5 months ago (2010-07-19 14:47:48 UTC) #2

The user agent value has to be terminated with \r\n. 
Additional \r\n should be placed at the end of all headers - but that has
nothing related with BeginningTransaction.
From what I have seen - MSHTML does not append additional \r\n. See
http://support.microsoft.com/kb/279497 as well for a sample.
Please revert.

Expand Messages | Collapse Messages