[binutils] Bump binutils to 2.20.1

binutils/gold/output.cc

 // output.cc -- manage the output file for gold
 
 // Copyright 2006, 2007, 2008, 2009 Free Software Foundation, Inc.
 // Written by Ian Lance Taylor <iant@google.com>.
 
 // This file is part of gold.
 
 // This program is free software; you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
 // the Free Software Foundation; either version 3 of the License, or
@@ skipping 1782 matching lines @@
     found_in_sections_clause_(false),
     has_load_address_(false),
     info_uses_section_index_(false),
     may_sort_attached_input_sections_(false),
     must_sort_attached_input_sections_(false),
     attached_input_sections_are_sorted_(false),
     is_relro_(false),
     is_relro_local_(false),
     is_small_section_(false),
     is_large_section_(false),
+    is_interp_(false),
+    is_dynamic_linker_section_(false),
+    generate_code_fills_at_write_(false),
     tls_offset_(0),
     checkpoint_(NULL),
     merge_section_map_(),
     merge_section_by_properties_map_(),
     relaxed_input_section_map_(),
-    is_relaxed_input_section_map_valid_(true),
-    generate_code_fills_at_write_(false)
+    is_relaxed_input_section_map_valid_(true)
 {
   // An unallocated section has no address.  Forcing this means that
   // we don't need special treatment for symbols defined in debug
   // sections.
   if ((flags & elfcpp::SHF_ALLOC) == 0)
     this->set_address(0);
 }
 
 Output_section::~Output_section()
 {
@@ skipping 1218 matching lines @@
     is_max_align_known_(false),
     are_addresses_set_(false),
     is_large_data_segment_(false)
 {
 }
 
 // Add an Output_section to an Output_segment.
 
 void
 Output_segment::add_output_section(Output_section* os,
-                                   elfcpp::Elf_Word seg_flags)
+                                   elfcpp::Elf_Word seg_flags,
+                                   bool do_sort)
 {
   gold_assert((os->flags() & elfcpp::SHF_ALLOC) != 0);
   gold_assert(!this->is_max_align_known_);
   gold_assert(os->is_large_data_section() == this->is_large_data_segment());
+  gold_assert(this->type() == elfcpp::PT_LOAD || !do_sort);
 
   // Update the segment flags.
   this->flags_ |= seg_flags;
 
   Output_segment::Output_data_list* pdl;
   if (os->type() == elfcpp::SHT_NOBITS)
     pdl = &this->output_bss_;
   else
     pdl = &this->output_data_;
 
-  // So that PT_NOTE segments will work correctly, we need to ensure
-  // that all SHT_NOTE sections are adjacent.  This will normally
-  // happen automatically, because all the SHT_NOTE input sections
-  // will wind up in the same output section.  However, it is possible
-  // for multiple SHT_NOTE input sections to have different section
-  // flags, and thus be in different output sections, but for the
-  // different section flags to map into the same segment flags and
-  // thus the same output segment.
-
   // Note that while there may be many input sections in an output
   // section, there are normally only a few output sections in an
-  // output segment.  This loop is expected to be fast.
+  // output segment.  The loops below are expected to be fast.
 
+  // So that PT_NOTE segments will work correctly, we need to ensure
+  // that all SHT_NOTE sections are adjacent.
   if (os->type() == elfcpp::SHT_NOTE && !pdl->empty())
     {
       Output_segment::Output_data_list::iterator p = pdl->end();
       do
         {
           --p;
           if ((*p)->is_section_type(elfcpp::SHT_NOTE))
             {
               ++p;
               pdl->insert(p, os);
               return;
             }
         }
       while (p != pdl->begin());
     }
 
   // Similarly, so that PT_TLS segments will work, we need to group
   // SHF_TLS sections.  An SHF_TLS/SHT_NOBITS section is a special
   // case: we group the SHF_TLS/SHT_NOBITS sections right after the
   // SHF_TLS/SHT_PROGBITS sections.  This lets us set up PT_TLS
   // correctly.  SHF_TLS sections get added to both a PT_LOAD segment
-  // and the PT_TLS segment -- we do this grouping only for the
-  // PT_LOAD segment.
+  // and the PT_TLS segment; we do this grouping only for the PT_LOAD
+  // segment.
   if (this->type_ != elfcpp::PT_TLS
       && (os->flags() & elfcpp::SHF_TLS) != 0)
     {
       pdl = &this->output_data_;
       if (!pdl->empty())
         {
           bool nobits = os->type() == elfcpp::SHT_NOBITS;
           bool sawtls = false;
           Output_segment::Output_data_list::iterator p = pdl->end();
           gold_assert(p != pdl->begin());
@@ skipping 109 matching lines @@
           if ((*p)->is_section()
               && (*p)->output_section()->is_large_section())
             {
               pdl->insert(p, os);
               return;
             }
         }
       gold_unreachable();
     }
 
+  // We do some further output section sorting in order to make the
+  // generated program run more efficiently.  We should only do this
+  // when not using a linker script, so it is controled by the DO_SORT
+  // parameter.
+  if (do_sort)
+    {
+      // FreeBSD requires the .interp section to be in the first page
+      // of the executable.  That is a more efficient location anyhow
+      // for any OS, since it means that the kernel will have the data
+      // handy after it reads the program headers.
+      if (os->is_interp() && !pdl->empty())
+        {
+          pdl->insert(pdl->begin(), os);
+          return;
+        }
+
+      // Put loadable non-writable notes immediately after the .interp
+      // sections, so that the PT_NOTE segment is on the first page of
+      // the executable.
+      if (os->type() == elfcpp::SHT_NOTE
+          && (os->flags() & elfcpp::SHF_WRITE) == 0
+          && !pdl->empty())
+        {
+          Output_segment::Output_data_list::iterator p = pdl->begin();
+          if ((*p)->is_section() && (*p)->output_section()->is_interp())
+            ++p;
+          pdl->insert(p, os);
+          return;
+        }
+
+      // If this section is used by the dynamic linker, and it is not
+      // writable, then put it first, after the .interp section and
+      // any loadable notes.  This makes it more likely that the
+      // dynamic linker will have to read less data from the disk.
+      if (os->is_dynamic_linker_section()
+          && !pdl->empty()
+          && (os->flags() & elfcpp::SHF_WRITE) == 0)
+        {
+          bool is_reloc = (os->type() == elfcpp::SHT_REL
+                           || os->type() == elfcpp::SHT_RELA);
+          Output_segment::Output_data_list::iterator p = pdl->begin();
+          while (p != pdl->end()
+                 && (*p)->is_section()
+                 && ((*p)->output_section()->is_dynamic_linker_section()
+                     || (*p)->output_section()->type() == elfcpp::SHT_NOTE))
+            {
+              // Put reloc sections after the other ones.  Putting the
+              // dynamic reloc sections first confuses BFD, notably
+              // objcopy and strip.
+              if (!is_reloc
+                  && ((*p)->output_section()->type() == elfcpp::SHT_REL
+                      || (*p)->output_section()->type() == elfcpp::SHT_RELA))
+                break;
+              ++p;
+            }
+          pdl->insert(p, os);
+          return;
+        }
+    }
+
+  // If there were no constraints on the output section, just add it
+  // to the end of the list.
   pdl->push_back(os);
 }
 
 // Remove an Output_section from this segment.  It is an error if it
 // is not present.
 
 void
 Output_segment::remove_output_section(Output_section* os)
 {
   // We only need this for SHT_PROGBITS.
@@ skipping 258 matching lines @@
           // better not have moved backward.
           if ((*p)->address() >= addr + (off - startoff))
             off += (*p)->address() - (addr + (off - startoff));
           else
             {
               if (!layout->script_options()->saw_sections_clause())
                 gold_unreachable();
               else
                 {
                   Output_section* os = (*p)->output_section();
+
+                  // Cast to unsigned long long to avoid format warnings.
+                  unsigned long long previous_dot =
+                    static_cast<unsigned long long>(addr + (off - startoff));
+                  unsigned long long dot =
+                    static_cast<unsigned long long>((*p)->address());
+
                   if (os == NULL)
                     gold_error(_("dot moves backward in linker script "
-                                 "from 0x%llx to 0x%llx"),
-                               addr + (off - startoff), (*p)->address());
+                                 "from 0x%llx to 0x%llx"), previous_dot, dot);
                   else
                     gold_error(_("address of section '%s' moves backward "
                                  "from 0x%llx to 0x%llx"),
-                               os->name(), addr + (off - startoff),
-                               (*p)->address());
+                               os->name(), previous_dot, dot);
                 }
             }
           (*p)->set_file_offset(off);
           (*p)->finalize_data_size();
         }
 
       // We want to ignore the size of a SHF_TLS or SHT_NOBITS
       // section.  Such a section does not affect the size of a
       // PT_LOAD segment.
       if (!(*p)->is_section_flag_set(elfcpp::SHF_TLS)
@@ skipping 829 matching lines @@
 template
 class Output_data_got<64, false>;
 #endif
 
 #ifdef HAVE_TARGET_64_BIG
 template
 class Output_data_got<64, true>;
 #endif
 
 } // End namespace gold.