Issue 3018021: media: player_wtl renderer forget to putCurrentFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3018021: media: player_wtl renderer forget to putCurrentFrame. (Closed)

Created:
10 years, 5 months ago by jiesun

Modified:
9 years, 7 months ago

Reviewers:
fbarchard, Alpha Left Google

CC:
chromium-reviews, scherkus (not reviewing), pam+watch_chromium.org, awong, fbarchard, Alpha Left Google

Visibility:
Public.

Description

media: player_wtl renderer forget to putCurrentFrame. forget to putCurrentFrame for this renderer. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53730

Patch Set 2 : typo #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	media/tools/player_wtl/view.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

fbarchard

I think you have a typo? http://codereview.chromium.org/3018021/diff/1/2 File media/tools/player_wtl/view.h (right): http://codereview.chromium.org/3018021/diff/1/2#newcode238 media/tools/player_wtl/view.h:238: renderer_->PetCurrentFrame(frame); Should be ...

10 years, 5 months ago (2010-07-26 21:43:30 UTC) #3

jiesun

10 years, 5 months ago (2010-07-26 21:52:15 UTC) #4

thanks, I test this on windows. so I try to commit in linux machine because I am
more familiar with that setup. I will try win bot before commit.

Expand Messages | Collapse Messages

Issue 3018021: media: player_wtl renderer forget to putCurrentFrame. (Closed)

Description

Patch Set 1 #

Patch Set 2 : typo #

Messages