Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 3018021: media: player_wtl renderer forget to putCurrentFrame. (Closed)

Created:
10 years, 5 months ago by jiesun
Modified:
9 years, 7 months ago
CC:
chromium-reviews, scherkus (not reviewing), pam+watch_chromium.org, awong, fbarchard, Alpha Left Google
Visibility:
Public.

Description

media: player_wtl renderer forget to putCurrentFrame. forget to putCurrentFrame for this renderer. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53730

Patch Set 1 #

Total comments: 1

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M media/tools/player_wtl/view.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jiesun
please review.
10 years, 5 months ago (2010-07-26 21:36:44 UTC) #1
Alpha Left Google
LGTM.
10 years, 5 months ago (2010-07-26 21:37:07 UTC) #2
fbarchard
I think you have a typo? http://codereview.chromium.org/3018021/diff/1/2 File media/tools/player_wtl/view.h (right): http://codereview.chromium.org/3018021/diff/1/2#newcode238 media/tools/player_wtl/view.h:238: renderer_->PetCurrentFrame(frame); Should be ...
10 years, 5 months ago (2010-07-26 21:43:30 UTC) #3
jiesun
10 years, 5 months ago (2010-07-26 21:52:15 UTC) #4
thanks, I test this on windows. so I try to commit in linux machine because I am
more familiar with that setup. I will try win bot before commit.

Powered by Google App Engine
This is Rietveld 408576698