Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1862)

Unified Diff: net/http/http_auth_handler_negotiate_unittest.cc

Issue 3018008: ASSERT_TRUE that the HttpAuthHandlerNegotiate::Factory creates non-NULL handlers. (Closed)
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_handler_negotiate_unittest.cc
diff --git a/net/http/http_auth_handler_negotiate_unittest.cc b/net/http/http_auth_handler_negotiate_unittest.cc
index ffc30ac1df43d87ed7b8660122b44392706d2def..59f615558c1ac6cca5b179d34344e2dbc11ea512 100644
--- a/net/http/http_auth_handler_negotiate_unittest.cc
+++ b/net/http/http_auth_handler_negotiate_unittest.cc
@@ -26,8 +26,6 @@ typedef net::test::MockGSSAPILibrary MockSecureServicesLibrary;
namespace net {
-// TODO(cbentzel): Remove the OS_WIN condition once Negotiate is supported
-// on all platforms.
namespace {
void SetupTransactions(MockSecureServicesLibrary* mock_library) {
@@ -163,6 +161,7 @@ TEST(HttpAuthHandlerNegotiateTest, DisableCname) {
scoped_ptr<HttpAuthHandlerNegotiate> auth_handler;
CreateHandler(true, false, true, "http://alias:500",
&mock_library, &auth_handler);
+ ASSERT_TRUE(auth_handler.get() != NULL);
TestCompletionCallback callback;
HttpRequestInfo request_info;
std::string token;
@@ -180,6 +179,7 @@ TEST(HttpAuthHandlerNegotiateTest, DisableCnameStandardPort) {
scoped_ptr<HttpAuthHandlerNegotiate> auth_handler;
CreateHandler(true, true, true,
"http://alias:80", &mock_library, &auth_handler);
+ ASSERT_TRUE(auth_handler.get() != NULL);
TestCompletionCallback callback;
HttpRequestInfo request_info;
std::string token;
@@ -197,6 +197,7 @@ TEST(HttpAuthHandlerNegotiateTest, DisableCnameNonstandardPort) {
scoped_ptr<HttpAuthHandlerNegotiate> auth_handler;
CreateHandler(true, true, true,
"http://alias:500", &mock_library, &auth_handler);
+ ASSERT_TRUE(auth_handler.get() != NULL);
TestCompletionCallback callback;
HttpRequestInfo request_info;
std::string token;
@@ -214,6 +215,7 @@ TEST(HttpAuthHandlerNegotiateTest, CnameSync) {
scoped_ptr<HttpAuthHandlerNegotiate> auth_handler;
CreateHandler(false, false, true,
"http://alias:500", &mock_library, &auth_handler);
+ ASSERT_TRUE(auth_handler.get() != NULL);
TestCompletionCallback callback;
HttpRequestInfo request_info;
std::string token;
@@ -231,6 +233,7 @@ TEST(HttpAuthHandlerNegotiateTest, CnameAsync) {
scoped_ptr<HttpAuthHandlerNegotiate> auth_handler;
CreateHandler(false, false, false,
"http://alias:500", &mock_library, &auth_handler);
+ ASSERT_TRUE(auth_handler.get() != NULL);
TestCompletionCallback callback;
HttpRequestInfo request_info;
std::string token;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698