Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4293)

Unified Diff: chrome/browser/tab_contents/render_view_context_menu.cc

Issue 3017047: Set a max limit on extension items' labels in context menus.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tab_contents/render_view_context_menu.h ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/render_view_context_menu.cc
===================================================================
--- chrome/browser/tab_contents/render_view_context_menu.cc (revision 54510)
+++ chrome/browser/tab_contents/render_view_context_menu.cc (working copy)
@@ -54,6 +54,11 @@
using WebKit::WebMediaPlayerAction;
// static
+const size_t RenderViewContextMenu::kMaxExtensionItemTitleLength = 75;
+// static
+const size_t RenderViewContextMenu::kMaxSelectionTextLength = 50;
+
+// static
bool RenderViewContextMenu::IsDevToolsURL(const GURL& url) {
return url.SchemeIs(chrome::kChromeUIScheme) &&
url.host() == chrome::kChromeUIDevToolsHost;
@@ -202,7 +207,8 @@
} else {
ExtensionMenuItem* item = items[0];
extension_item_map_[menu_id] = item->id();
- title = item->TitleWithReplacement(PrintableSelectionText());
+ title = item->TitleWithReplacement(PrintableSelectionText(),
+ kMaxExtensionItemTitleLength);
submenu_items = GetRelevantExtensionItems(item->children(), params_);
}
@@ -243,7 +249,8 @@
if (menu_id >= IDC_EXTENSIONS_CONTEXT_CUSTOM_LAST)
return;
extension_item_map_[menu_id] = item->id();
- string16 title = item->TitleWithReplacement(selection_text);
+ string16 title = item->TitleWithReplacement(selection_text,
+ kMaxExtensionItemTitleLength);
if (item->type() == ExtensionMenuItem::NORMAL) {
ExtensionMenuItem::List children =
GetRelevantExtensionItems(item->children(), params_);
@@ -1367,7 +1374,8 @@
}
string16 RenderViewContextMenu::PrintableSelectionText() {
- return WideToUTF16(l10n_util::TruncateString(params_.selection_text, 50));
+ return WideToUTF16(l10n_util::TruncateString(params_.selection_text,
+ kMaxSelectionTextLength));
}
// Controller functions --------------------------------------------------------
« no previous file with comments | « chrome/browser/tab_contents/render_view_context_menu.h ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698