DOMUI prefs: Remove use of tables for layout on the Under the Hood pane.

DOMUI prefs: Remove use of tables for layout on the Under the Hood pane.

BUG=none
TEST=DOMUI Under the Hood options still display correctly.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54178

[stuartmorgan, 2010-07-28 19:55:32]

We may eventually need grouping divs around each conceptual pref for styling,
but that'll be just as easy to add later, and I don't want to add structural
elements until we know we'll need them.

[csilv, 2010-07-28 20:55:49]

LGTM

I wonder if the <br>'s are the best choice... they strike me as a little too
biases towards what the layout should be.  Perhaps it would be better to enclose
each "line" in a <div> instead?  This should accomplish the same thing as the
<br> and should provide more flexibility via css.  But maybe i'm off base... I'd
be curious what the CSS experts think.

[arv (Not doing code reviews), 2010-07-28 21:18:32]

On Wed, Jul 28, 2010 at 13:55,  <csilv@chromium.org> wrote:
> LGTM
>
> I wonder if the <br>'s are the best choice... they strike me as a little too
> biases towards what the layout should be.  Perhaps it would be better to
> enclose
> each "line" in a <div> instead?  This should accomplish the same thing as
> the
> <br> and should provide more flexibility via css.  But maybe i'm off base...
> I'd
> be curious what the CSS experts think.

I agree with you, two elements with display block is usually better.

-- 
erik

[stuartmorgan, 2010-07-28 22:32:45]

Switched to divs, with one exception: it seemed a bit weird to wrap every
<label> in a div when I can't ever image we'd want two on the same line anyway,
so I made label block-level directly.

If anyone feels strongly that adding more divs instead is better though, I'll go
that route.

[arv (Not doing code reviews), 2010-07-28 23:43:15]

labels with display: block sounds like the right solution to me.

erik



On Wed, Jul 28, 2010 at 15:32,  <stuartmorgan@chromium.org> wrote:
> Switched to divs, with one exception: it seemed a bit weird to wrap every
> <label> in a div when I can't ever image we'd want two on the same line
> anyway,
> so I made label block-level directly.
>
> If anyone feels strongly that adding more divs instead is better though,
> I'll go
> that route.
>
> http://codereview.chromium.org/3017039/show
>

[dhg, 2010-07-29 20:06:21]

LGTM
On 2010/07/28 23:43:15, arv wrote:
> labels with display: block sounds like the right solution to me.
> 
> erik
> 
> 
> 
> On Wed, Jul 28, 2010 at 15:32,  <mailto:stuartmorgan@chromium.org> wrote:
> > Switched to divs, with one exception: it seemed a bit weird to wrap every
> > <label> in a div when I can't ever image we'd want two on the same line
> > anyway,
> > so I made label block-level directly.
> >
> > If anyone feels strongly that adding more divs instead is better though,
> > I'll go
> > that route.
> >
> > http://codereview.chromium.org/3017039/show
> >
>

[arv (Not doing code reviews), 2010-07-30 17:49:23]

LGTM