views: Fix bad license headers found in some files

views: Fix bad license headers found in some files

BUG=50266
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53974

[Nico, 2010-07-28 16:09:53]

LG

http://codereview.chromium.org/3017036/diff/1/2
File views/controls/button/native_button_gtk.h (right):

http://codereview.chromium.org/3017036/diff/1/2#newcode7
views/controls/button/native_button_gtk.h:7: 
no newline here

(also in the other files)

http://codereview.chromium.org/3017036/diff/1/2#newcode105
views/controls/button/native_button_gtk.h:105: 
newline not necessary here either (the c++ styleguide even recommends to not use
too many newlines

http://codereview.chromium.org/3017036/diff/1/2#newcode108
views/controls/button/native_button_gtk.h:108: 
no newline

http://codereview.chromium.org/3017036/diff/1/14
File views/views_delegate.h (right):

http://codereview.chromium.org/3017036/diff/1/14#newcode16
views/views_delegate.h:16: 
this newline is ok :-)

[tfarina, 2010-07-28 16:58:32]

http://codereview.chromium.org/3017036/diff/1/2
File views/controls/button/native_button_gtk.h (right):

http://codereview.chromium.org/3017036/diff/1/2#newcode7
views/controls/button/native_button_gtk.h:7: 
On 2010/07/28 16:09:53, Nico wrote:
> no newline here
> 
> (also in the other files)

Done.

http://codereview.chromium.org/3017036/diff/1/2#newcode105
views/controls/button/native_button_gtk.h:105: 
On 2010/07/28 16:09:53, Nico wrote:
> newline not necessary here either (the c++ styleguide even recommends to not
use
> too many newlines
I'd like to keep the newlines, just for readability.

[Nico, 2010-07-28 17:13:06]

I won't stop this CL over the issue below. If you feel strongly, commit this CL
as is. I'm just trying to prevent changes that could be changed back-and-forth
indefinitely.

http://codereview.chromium.org/3017036/diff/1/2
File views/controls/button/native_button_gtk.h (right):

http://codereview.chromium.org/3017036/diff/1/2#newcode105
views/controls/button/native_button_gtk.h:105: 
On 2010/07/28 16:58:32, tfarina wrote:
> On 2010/07/28 16:09:53, Nico wrote:
> > newline not necessary here either (the c++ styleguide even recommends to not
> use
> > too many newlines
> I'd like to keep the newlines, just for readability.
> 

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Vertical_White...
:

"""This is more a principle than a rule: don't use blank lines when you don't
have to. In particular, don't put more than one or two blank lines between
functions, don't start or end functions with a blank line, and be discriminating
with your use of blank lines inside functions.

The basic principle is: The more code that fits on one screen, the easier it is
to follow and understand the control flow of the program. Of course, readability
can suffer from code being too dense as well as too spread out, so use your
judgement. But in general, minimize use of vertical whitespace.
"""

I don't mind putting newlines between function declarations, but not having them
is explicitly permitted. If the original author wrote them without newlines,
adding just because of personal taste seems not productive. I recommend you get
used to this style too :-)

[tfarina, 2010-07-28 17:23:35]

On 2010/07/28 17:13:06, Nico wrote:
> I don't mind putting newlines between function declarations, but not having
them
> is explicitly permitted. If the original author wrote them without newlines,
> adding just because of personal taste seems not productive. I recommend you
get
> used to this style too :-)

I just thought that would be good and more easy to read, but it seems that is
not the case. (I will remember to let my personal taste aside in future :( ).
Reverted the change.