Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: chrome/browser/resources/options/options_page.js

Issue 3017027: Small tweak to avoid pushing overlay URLs. This prevents overlays URLs from... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/options_page.js
===================================================================
--- chrome/browser/resources/options/options_page.js (revision 53424)
+++ chrome/browser/resources/options/options_page.js (working copy)
@@ -146,13 +146,14 @@
return;
if (visible) {
- window.history.pushState({pageName: this.name},
- this.title,
- '/' + this.name);
this.pageDiv.style.display = 'block';
if (this.isOverlay) {
var overlay = $('overlay');
overlay.classList.remove('hidden');
+ } else {
+ window.history.pushState({pageName: this.name},
+ this.title,
+ '/' + this.name);
}
if (this.tab) {
this.tab.classList.add('navbar-item-selected');
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698