Fix break position not to be outside of the script

Fix break position not to be outside of the script

Committed: http://code.google.com/p/v8/source/detail?r=5131

[podivilov, 2010-07-23 11:42:43]

http://codereview.chromium.org/3017021/diff/5001/6001
File src/runtime.cc (right):

http://codereview.chromium.org/3017021/diff/5001/6001#newcode9346
src/runtime.cc:9346: // The result position may become beyound script source
end. This may become
typo: beyound -> beyond

http://codereview.chromium.org/3017021/diff/5001/6001#newcode9353
src/runtime.cc:9353: }
When we set a breakpoint after all statements in function, it is actually set on
the first character after function body (which is shared->end_position()). Since
scripts in v8 always have a new line character at the end, this can cause
problems only for top level function.
Please consider using more targeted code here, e.g.:
    if (shared->is_toplevel() && position == shared->end_position()) {
        position = shared->end_position() - 1;
    }

http://codereview.chromium.org/3017021/diff/5001/6002
File test/mjsunit/debug-setbreakpoint.js (right):

http://codereview.chromium.org/3017021/diff/5001/6002#newcode197
test/mjsunit/debug-setbreakpoint.js:197: // Breakpoint in a script with no
statements test case. If breakpoint is set to the script
style: long line

http://codereview.chromium.org/3017021/diff/5001/6002#newcode199
test/mjsunit/debug-setbreakpoint.js:199: // case is reset to the very end of the
script. Unless some precautions made, thi
typo: thi -> this

http://codereview.chromium.org/3017021/diff/5001/6002#newcode212
test/mjsunit/debug-setbreakpoint.js:212: // moment. Since we there's no way of
simply getting the pointer to the function,
typo: unnecessary we

[Peter Rybin, 2010-07-23 16:38:21]

http://codereview.chromium.org/3017021/diff/5001/6001
File src/runtime.cc (right):

http://codereview.chromium.org/3017021/diff/5001/6001#newcode9346
src/runtime.cc:9346: // The result position may become beyound script source
end. This may become
On 2010/07/23 11:42:44, podivilov wrote:
> typo: beyound -> beyond

Done.

http://codereview.chromium.org/3017021/diff/5001/6001#newcode9353
src/runtime.cc:9353: }
On 2010/07/23 11:42:44, podivilov wrote:
> When we set a breakpoint after all statements in function, it is actually set
on
> the first character after function body (which is shared->end_position()).
Since
> scripts in v8 always have a new line character at the end, this can cause
> problems only for top level function.
> Please consider using more targeted code here, e.g.:
>     if (shared->is_toplevel() && position == shared->end_position()) {
>         position = shared->end_position() - 1;
>     }
> 

Done.

http://codereview.chromium.org/3017021/diff/5001/6002
File test/mjsunit/debug-setbreakpoint.js (right):

http://codereview.chromium.org/3017021/diff/5001/6002#newcode197
test/mjsunit/debug-setbreakpoint.js:197: // Breakpoint in a script with no
statements test case. If breakpoint is set to the script
On 2010/07/23 11:42:44, podivilov wrote:
> style: long line

Done.

http://codereview.chromium.org/3017021/diff/5001/6002#newcode199
test/mjsunit/debug-setbreakpoint.js:199: // case is reset to the very end of the
script. Unless some precautions made, thi
On 2010/07/23 11:42:44, podivilov wrote:
> typo: thi -> this

Done.

http://codereview.chromium.org/3017021/diff/5001/6002#newcode212
test/mjsunit/debug-setbreakpoint.js:212: // moment. Since we there's no way of
simply getting the pointer to the function,
On 2010/07/23 11:42:44, podivilov wrote:
> typo: unnecessary we

Done.

[podivilov, 2010-07-23 16:55:36]

http://codereview.chromium.org/3017021/diff/11001/12002
File test/mjsunit/debug-setbreakpoint.js (right):

http://codereview.chromium.org/3017021/diff/11001/12002#newcode208
test/mjsunit/debug-setbreakpoint.js:208:
Debug.setScriptBreakPoint(Debug.ScriptBreakPointType.ScriptId, i_script.id, 4);
style: long line

[podivilov, 2010-07-23 16:55:43]

LGTM