Refactoring key generation and export util code to make mocking possible.

Refactoring key generation and export util code to make mocking possible.

BUG=chromium-os:4485
TEST=unit tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53292

[Chris Masone, 2010-07-21 20:55:26]

Hey, dave.  Did I use factories right?

[DaveMoore, 2010-07-21 22:17:29]

http://codereview.chromium.org/3017020/diff/3006/7002
File chrome/browser/chromeos/login/owner_key_utils.h (right):

http://codereview.chromium.org/3017020/diff/3006/7002#newcode28
chrome/browser/chromeos/login/owner_key_utils.h:28: virtual ~OwnerKeyUtils() {}
We discovered a big enough cost in compiler time to the inline constructors /
destructors (and they pretty much never get inlined anyway) that we're getting
rid of them across Chrome.

http://codereview.chromium.org/3017020/diff/3006/7002#newcode69
chrome/browser/chromeos/login/owner_key_utils.h:69: class OwnerKeyUtilsImpl :
public OwnerKeyUtils {
Does this need to be visible anymore?

http://codereview.chromium.org/3017020/diff/3006/7002#newcode71
chrome/browser/chromeos/login/owner_key_utils.h:71: OwnerKeyUtilsImpl() {}
Ditto on these

[Chris Masone, 2010-07-21 23:32:31]

Weird.  It's now decided that I deleted a header and added another, instead of
calling it a move.  Whatever.  PTAL

http://codereview.chromium.org/3017020/diff/3006/7002
File chrome/browser/chromeos/login/owner_key_utils.h (right):

http://codereview.chromium.org/3017020/diff/3006/7002#newcode28
chrome/browser/chromeos/login/owner_key_utils.h:28: virtual ~OwnerKeyUtils() {}
On 2010/07/21 22:17:29, davemoore wrote:
> We discovered a big enough cost in compiler time to the inline constructors /
> destructors (and they pretty much never get inlined anyway) that we're getting
> rid of them across Chrome.

Done.

http://codereview.chromium.org/3017020/diff/3006/7002#newcode69
chrome/browser/chromeos/login/owner_key_utils.h:69: class OwnerKeyUtilsImpl :
public OwnerKeyUtils {
On 2010/07/21 22:17:29, davemoore wrote:
> Does this need to be visible anymore?

Moved to .cc

http://codereview.chromium.org/3017020/diff/3006/7002#newcode71
chrome/browser/chromeos/login/owner_key_utils.h:71: OwnerKeyUtilsImpl() {}
On 2010/07/21 22:17:29, davemoore wrote:
> Ditto on these

Done.

[DaveMoore, 2010-07-22 00:56:33]

LGTM