Issue 3017018: Change asserts to STATIC_ASSERT if they can be checked at compilation time. ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3017018: Change asserts to STATIC_ASSERT if they can be checked at compilation time. ... (Closed)

Created:
10 years, 5 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Change asserts to STATIC_ASSERT if they can be checked at compilation time. Just in the codegen-xxx.cc files on all platforms. Committed: http://code.google.com/p/v8/source/detail?r=5121

Patch Set 3 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+220 lines, -214 lines)			Patch
M	src/arm/codegen-arm.cc	View	1 2	61 chunks	+78 lines, -78 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1 2	71 chunks	+101 lines, -95 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1 2	31 chunks	+41 lines, -41 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

http://codereview.chromium.org/3017018/diff/1/2 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/3017018/diff/1/2#newcode818 src/arm/codegen-arm.cc:818: STATIC_ASSERT(0 == kSmiTag); sometimes you have == 0 sometimes ...

10 years, 5 months ago (2010-07-22 09:16:15 UTC) #2

LGTM

Expand Messages | Collapse Messages

Issue 3017018: Change asserts to STATIC_ASSERT if they can be checked at compilation time. ... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages