Issue 3017007: Introduce "--enable-memory-info" command-line flag to enable reporting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3017007: Introduce "--enable-memory-info" command-line flag to enable reporting (Closed)

Created:
10 years, 5 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Visibility:
Public.

Description

Introduce "--enable-memory-info" command-line flag to enable reporting of JS heap size via "console.memory" (for now) and "webkitPerformance.memory" (having Web Timing enabled). BUG=43281 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52886

Patch Set 1 #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -2 lines)			Patch
M	chrome/browser/tab_contents/render_view_host_delegate_helper.cc	View	1 chunk	+2 lines, -0 lines	1 comment	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/render_messages.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	webkit/glue/webpreferences.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	webkit/glue/webpreferences.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pfeldman

10 years, 5 months ago (2010-07-16 11:25:12 UTC) #2

LGTM

http://codereview.chromium.org/3017007/diff/1/2
File chrome/browser/tab_contents/render_view_host_delegate_helper.cc (right):

http://codereview.chromium.org/3017007/diff/1/2#newcode272
chrome/browser/tab_contents/render_view_host_delegate_helper.cc:272:
command_line.HasSwitch(switches::kEnableMemoryInfo);
kEnablePerformanceMemoryInfo ?

Expand Messages | Collapse Messages