Issue 3017006: AU: pass whether or not we can tolerate a delta to the server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3017006: AU: pass whether or not we can tolerate a delta to the server (Closed)

Created:
10 years, 5 months ago by adlr

Modified:
9 years ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/update_engine.git

Visibility:
Public.

Description

AU: pass whether or not we can tolerate a delta to the server BUG=4848 TEST=attached unittests

Patch Set 2 : merge master (which has petkov's CL in) #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -1 line)			Patch
M	omaha_request_action.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	omaha_request_action_unittest.cc	View	1	16 chunks	+45 lines, -0 lines	0 comments	Download
M	omaha_request_params.h	View		3 chunks	+3 lines, -0 lines	0 comments	Download
M	omaha_request_params.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	omaha_request_params_unittest.cc	View		2 chunks	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

adlr

I patched in your un-checked-in CL, so this should go in after that.

10 years, 5 months ago (2010-07-16 03:05:53 UTC) #1

petkov

LGTM http://codereview.chromium.org/3017006/diff/1/4 File omaha_request_params.cc (right): http://codereview.chromium.org/3017006/diff/1/4#newcode41 omaha_request_params.cc:41: struct stat stbuf; I'd move this declaration closer ...

10 years, 5 months ago (2010-07-16 04:12:38 UTC) #2

petkov

On 2010/07/16 03:05:53, adlr wrote: > I patched in your un-checked-in CL, so this should ...

10 years, 5 months ago (2010-07-16 05:25:29 UTC) #3